Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: position hide code button above or below depending on outputArea #3522

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

Light2Dark
Copy link
Collaborator

📝 Summary

Fixes #3521 .

cell output below
image

cell output above
image

🔍 Description of Changes

I remember you mentioned react can be funky with how we dynamically create these components. Not sure if this is the ideal way.

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
JamesNK James Newton-King
Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 0:16am

Copy link

vercel bot commented Jan 21, 2025

@Light2Dark is attempting to deploy a commit to the marimo Team on Vercel.

A member of the Team first needs to authorize it.

@mscolnick mscolnick merged commit fcadec7 into marimo-team:main Jan 21, 2025
19 of 20 checks passed
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.16-dev10

@Light2Dark Light2Dark deleted the hide-code-btn-dynamic branch January 21, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Edit Markdown" button should respect the "cell output area = below" setting
2 participants