Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize fastapi-github example with environment vars #3078

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

manzt
Copy link
Contributor

@manzt manzt commented Dec 6, 2024

📝 Summary

Detects GITHUB_REPO and REPO_ROOT environment variables if set,
falling back to default in marimo.

(I believe this is the desired behavior of the script)

🔍 Description of Changes

Just detects GITHUB_REPO and REPO_ROOT environment variables if set.

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@mscolnick

Sorry, something went wrong.

Detects `GITHUB_REPO` and `REPO_ROOT` environment variables if set,
falling back to default in marimo.
Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 3:46pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 3:46pm

@manzt manzt changed the title Parameterize fastapi-github example script with envars Parameterize fastapi-github example with environment vars Dec 6, 2024
@mscolnick mscolnick merged commit 4129e02 into marimo-team:main Dec 6, 2024
19 checks passed
@manzt manzt deleted the manzt/parameterize-script branch December 6, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants