Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the diff module to v5.2.0 for performance improvements #201

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

v-hal
Copy link
Contributor

@v-hal v-hal commented Apr 17, 2024

Update diff from v3.5.0 to v5.2.0. The update includes significant performance improvements (jsdiff/#448 & jsdiff/#411) which makes it possible to diff larger CloudFormation templates.

For a full list of changes, see the changelog: https://github.com/kpdecker/jsdiff/blob/master/release-notes.md.

Review of breaking changes between version 3.5.0 and 5.2.0

v5.0.0

  • Breaking: UMD export renamed from JsDiff to Diff.

We are not affected, since cfn-config doesn't use UMD imports.

  • Breaking: Newlines separated into separate tokens for word diff.

Changes in kpdecker/jsdiff#217 affect the diff return value of the diffWords function. We don't use diffWordsin cfn.config.

  • Breaking: Unified diffs now match "quirks"

cfn-config doesn't use the unified diff output. The changes in kpdecker/jsdiff#297 affect how unified diff chunks are formatted.

v4.0.0 - January 5th, 2019

Changes in kpdecker/jsdiff#94 affect only patches in unified diff format, which are not used in cfn-config.

Changes affect only patches in unified diff format, which are not used in cfn-config.

  • Drop ie9 from karma targets - 79c31bd

cfn-config is not affected by browser targets.

  • Make ()[]"' as word boundaries between each other - f27b899

Changes in kpdecker/jsdiff@f27b899 affect word diffs, which are not used in cfn-config.

  • Compatibility notes: Bower and Component packages no longer supported

cfn-config doesn't use bower.

@v-hal v-hal requested a review from a team as a code owner April 17, 2024 08:04
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@bilindhajer bilindhajer merged commit 3171230 into master Apr 22, 2024
3 checks passed
@bilindhajer bilindhajer deleted the update-diff-module branch April 22, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants