Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ember qunit less than v6 #2031

Merged

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Sep 27, 2023

In preparation for making the v2 conversion flow, starting in #2027 easier, I'm extracting some of the more isolated changes.

For an overall plan for how v2 addon conversion works,

Also, in part, to help with maintenance burden, supporting less is easier as well. ember-qunit is on v8 now, and v4 and v5 are very old and have "magic" build-time behavior, which can't be transferred to the v2 addon world.

Up next will be upgrading the embroider deps, because < v3 isn't really supported 🙃


Outstanding questions for the maintainers:

  • I've added a note to the README about installing older (aka, todays) qunit-dom, if folks have older ember-qunit -- with these changes it would still (probably) be possible to use with older ember-qunit, but all the automatic setup stuff would need to be handled by the consumer.

Things to keep in mind: In my subsequent PRs to qunit-dom, there may be more breaking changes. I'll make sure each is called out in the PR that introduces them, if not extracted to a separate PR (which would be my preference, depending on the situation that calls for the change)

},
},
},
{
name: 'ember-qunit-5',
name: 'ember-lts-4.12',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added the latest v4 LTS here, since we want some matrix in our matrix

pnpm-lock.yaml Outdated Show resolved Hide resolved
@BobrImperator BobrImperator merged commit c4d3512 into mainmatter:master Oct 6, 2023
9 checks passed
@NullVoxPopuli NullVoxPopuli deleted the drop-ember-qunit-less-than-v6 branch October 6, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants