Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pe: add COFF object file support #379

Merged
merged 1 commit into from
Sep 25, 2023
Merged

pe: add COFF object file support #379

merged 1 commit into from
Sep 25, 2023
+15 −4

Conversation

vadimcn
Copy link
Contributor

@vadimcn vadimcn commented Sep 15, 2023

Fixes #324

@vadimcn
pe: add COFF object file support

Verified

This commit was signed with the committer’s verified signature.
richardlau Richard Lau
GPG key ID: C43CEC45C17AB93C
Verified
Learn about vigilant mode
a22d2d7
m4b
m4b approved these changes Sep 25, 2023
View reviewed changes
Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'm wondering if we should add non-exhaustive to the Hint enum, but this is fine for now (and breaking change either way)

@m4b m4b merged commit 1c36668 into m4b:master Sep 25, 2023
@m4b
Copy link
Owner

m4b commented Sep 25, 2023

NB breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4b m4b

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for COFF object files
2 participants
@vadimcn @m4b