-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pe: add authenticode support / v2 #362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is much more palatable, thank you for making these changes so quickly!
We don't need these feature flags, as I mentioned we also tuck the mach-o bytes inside the struct, so this isn't an unusual pattern already. Otherwise just some minor things/changes I noted, but this looks ok to me :)
caf2324
to
4a918d8
Compare
Authenticode is the hashing format used to sign PE binaries. This provides the hash to be signed.
4a918d8
to
fec3ad9
Compare
anything missing or can we merge as this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This is great @baloo sorry for delay and thanks for making these changes! |
non-breaking |
released in 0.7.0, thank you so much for your patience! |
Alternative to #358
This removes the
digest
dependency and allows to implement hashing like: