Fix Porgressbar rendering Checkbox (Fixes #1626) #1627
Merged
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added: - OutputMode::Task - task.rs formatter
fixed: - if no color support the checkbox mode didn't work - progress render now uses the default option instead of checkbox
mre
reviewed
Feb 6, 2025
mre
reviewed
Feb 6, 2025
mre
reviewed
Feb 6, 2025
mre
reviewed
Feb 6, 2025
mre
reviewed
Feb 6, 2025
mre
reviewed
Feb 6, 2025
|
Code looks fine. Just added a few more remarks about comment formatting. Other than that, we're good to go. 😊 |
Co-authored-by: Matthias Endler <matthias@endler.dev>
Co-authored-by: Matthias Endler <matthias@endler.dev>
Co-authored-by: Matthias Endler <matthias@endler.dev>
Co-authored-by: Matthias Endler <matthias@endler.dev>
mre
approved these changes
Feb 6, 2025
|
Thanks @Arteiii 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the checkbox rendering in the progressbar and the checkbox not working in no color mode.
couldn't think of a better looking formatter for the progressbar, maybe someone else has an idea LMK