Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated matchers to account for "./" file prefixes #42

Merged
merged 2 commits into from
Nov 14, 2021

Conversation

fearphage
Copy link
Contributor

The files are shown with a ./ prefix so they fail to string match the files on the disk. This updates the regex to account for this prefix.

Sample output:

##[debug]Checking ./catpants.sh
##[debug]Checking ./deploy-all-the-things.sh
Error: ./deploy-all-the-things.sh:116:6: error: Couldn't parse this test expression. Fix to allow more checks. [SC1073]
Error: ./deploy-all-the-things.sh:127:30: error: Expected test to end here (don't wrap commands in []/[[]]). Fix any mentioned problems and try again. [SC1072]
##[debug]Checking ./foo-bar

Since ./deploy-all-the-things.sh does not match deploy-all-the-things.sh, it would not annotate the file.

@fearphage
Copy link
Contributor Author

@ludeeus Bump.

@fearphage
Copy link
Contributor Author

@ludeeus Another attempt at getting your attention.

@ludeeus ludeeus added this to the 1.2.0 milestone Nov 1, 2021
Copy link
Owner

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ludeeus ludeeus merged commit a108013 into ludeeus:master Nov 14, 2021
@fearphage fearphage deleted the fix-matcher branch November 15, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants