make sure all chars are replaced, fix issue anchore#396

Signed-off-by: lts-po <philip@supernetworks.org>
lts-po · May 3, 2023 · 2be1457 · 2be1457
1 parent ea7104d
commit 2be1457
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 4 deletions.
diff --git a/dist/attachReleaseAssets/index.js b/dist/attachReleaseAssets/index.js
diff --git a/dist/downloadSyft/index.js b/dist/downloadSyft/index.js
diff --git a/dist/runSyftAction/index.js b/dist/runSyftAction/index.js
diff --git a/src/github/SyftGithubAction.ts b/src/github/SyftGithubAction.ts
@@ -71,7 +71,7 @@ export function getArtifactName(): string {
     if (parts.length > 2) {
       parts.splice(0, 1);
     }
-    const prefix = parts.join("-").replace(/[^-a-zA-Z0-9]/, "_");
+    const prefix = parts.join("-").replace(/[^-a-zA-Z0-9]/g, "_");
     return `${prefix}.${extension}`;
   }
 

diff --git a/tests/SyftGithubAction.test.ts b/tests/SyftGithubAction.test.ts
@@ -385,6 +385,17 @@ describe("Action", () => {
     });
 
     expect(action.getArtifactName()).toBe("img.cyclonedx.json");
+
+  });
+
+  it("correctly encode tags", () => {
+    setData({
+      inputs: {
+        image: "ghcr.io/something-something/image-image:0.1.2-dev"
+      }
+    });
+
+    expect(action.getArtifactName()).toBe("something-something-image-image_0_1_2-dev.spdx.json");
   });
 
   it ("properly maps paths for WSL", () => {