Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruff complaint about c-style formatting #1004

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

dhirving
Copy link
Contributor

@dhirving dhirving commented Apr 26, 2024

The new version of ruff no longer allows '%' formatting, instead requiring the use of f-strings.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

The new version of ruff no longer allows '%' formatting, instead requiring the use of f-strings.
@timj
Copy link
Member

timj commented Apr 26, 2024

Looks like v0.4.2 of ruff enhanced the UP031 rule detection: astral-sh/ruff#11019

@dhirving dhirving marked this pull request as ready for review April 26, 2024 00:18
@dhirving dhirving requested a review from timj April 26, 2024 00:18
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.04%. Comparing base (ecffc00) to head (585f067).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1004   +/-   ##
=======================================
  Coverage   89.04%   89.04%           
=======================================
  Files         347      347           
  Lines       44473    44473           
  Branches     9146     9146           
=======================================
  Hits        39601    39601           
  Misses       3550     3550           
  Partials     1322     1322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhirving dhirving merged commit df7acb9 into main Apr 26, 2024
18 checks passed
@dhirving dhirving deleted the u/dhirving/fix-ruff-error branch April 26, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants