Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clippy warnings produced with Rust 1.78.0 #94

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

imor
Copy link
Contributor

@imor imor commented Jun 30, 2024

Most clippy warnings were about empty doc comments. One was about using clone_from instead of clone which needed a bit of code reorg.

Verified

This commit was signed with the committer’s verified signature.
oteffahi Oussama Teffahi
@imor imor changed the title fix clippy warnings produced with 1.78.0 fix clippy warnings produced with Rust 1.78.0 Jul 1, 2024
@lquerel
Copy link
Owner

lquerel commented Jul 2, 2024

Thank you for this contribution. I am on vacation until the beginning of next week. I will review this PR when I return.

Copy link
Owner

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@lquerel lquerel merged commit 5dd0052 into lquerel:main Jul 7, 2024
@imor imor deleted the fix_clippy_warnings branch July 8, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants