Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base64 to runtime dependency #1525

Merged
merged 1 commit into from
Aug 15, 2023

Commits on Aug 15, 2023

  1. Add base64 to runtime dependency

    This PR add `base64` to runtime dependency to suppress the following Ruby 3.3's warning:
    
    ```console
    $ ruby -ve 'require "faraday"'
    ruby 3.3.0dev (2023-08-14T15:48:39Z master 52837fcec2) [x86_64-darwin22]
    /Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/faraday-2.7.10/lib/faraday/utils.rb:3:
    warning: base64 which will be not part of the default gems since Ruby 3.4.0
    ```
    
    cf: rails/rails#48907
    koic committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    7fe98f3 View commit details
    Browse the repository at this point in the history