Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix included middleware links #1522

Merged

Conversation

edwardloveall
Copy link
Contributor

@edwardloveall edwardloveall commented Aug 6, 2023

Description

Hi 馃憢馃徎 Thanks for maintaining Faraday.

The "Available Middleware" links on the Middleware Overview page were pointing to /middleware/___ instead of /middleware/included/___. I updated them to point to the correct place.

Todos

List any remaining work that needs to be done, i.e:

  • Tests (N/A I think)
  • Documentation

The links were pointing to `/middleware/___` instead of
`/middleware/included/___`
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @edwardloveall! I tried it and it now works right!

@olleolleolle olleolleolle merged commit 26168c4 into lostisland:main Aug 7, 2023
8 checks passed
@edwardloveall edwardloveall deleted the el-fix-middleware-links branch August 7, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants