Fix some logging inefficiencies #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMacTia
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Thank you @semaperepelitsa for addressing these performance issues 🙌 !
This LGTM, we just have a minor rubocop offense.
The suggested fix from Rubocop works, but it's not ideal in this particular case, so if you prefer you could try moving @filter initialisation after @options and that should also solve the offense 👍
|
@iMacTia, done! Related PR: #1079 cc @amrrbakry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reviewing Faraday logger I noticed two inefficiencies:
This PR fixes both issues.