Raise Error: Add Faraday::RequestTimeoutError #1513
Conversation
There was a problem hiding this comment.
Thank you, @tisba!
The MDN URLs look great. The new error class follows convention.
Let's get this merged!
| On newer Ruby versions (>= 3.0) `eventmachine` needs a little help to find OpenSSL 1.1 to get compiled (see <https://github.com/eventmachine/eventmachine/issues/936>). If you're using homebrew on macOS, you can do this: | ||
|
|
||
| ```bash | ||
| brew install openssl@1.1 | ||
| bundle config build.eventmachine --with-openssl-dir=$(brew --prefix openssl@1.1) | ||
| bundle install | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Thank you for pointing this out @tisba.
Faraday doesn't bundle an eventmachine adapter since v2.0, so people should not have this issue unless they're using https://github.com/lostisland/faraday-em_http or https://github.com/lostisland/faraday-em_synchrony.
I'd suggest moving this suggestion in those gems because eventmachine is not a dependency in this gem
There was a problem hiding this comment.
I thought this was about the "get Jekyll running, to view docs"? I could be wrong!
There was a problem hiding this comment.
What @olleolleolle said. This is about getting the docs running locally.
There was a problem hiding this comment.
really?! Well that's a surprise 😄!
In that case, thanks for the addition 🙏 !
There was a problem hiding this comment.
In Gemfile:
github-pages was resolved to 228, which depends on
jekyll-avatar was resolved to 0.7.0, which depends on
jekyll was resolved to 3.9.3, which depends on
em-websocket was resolved to 0.5.3, which depends on
eventmachine
yup, coming form the docs/Gemfile, good catch!
Fixes #1511
This PR adds
Faraday::RequestTimeoutErrorand raises it on HTTP 408 responses when the Raise Error Middleware is used.I also took the liberty to hint out how to get
eventmachineinstalled with Ruby >= 3.0 to work ondocs/.Let me know if this works for you or if you expect something in addition. I basically just copy-pasted the new error looking at the surrounding code 😀