Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implementation of Faraday::Error helpers. #1510

Merged
merged 1 commit into from Jun 19, 2023
Merged

Fix implementation of Faraday::Error helpers. #1510

merged 1 commit into from Jun 19, 2023

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Jun 15, 2023

Fix #1509

Description

Fix implementation of Faraday::Error helpers.
Fixes #1509

Todos

List any remaining work that needs to be done, i.e:

  • Tests

@iMacTia iMacTia self-assigned this Jun 15, 2023
olleolleolle
olleolleolle approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A vast improvement, and now the "can be nil" is at least the defined behaviour.

Good stuff!

brendo
brendo approved these changes Jun 15, 2023
View reviewed changes
Copy link

@brendo brendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can confirm that copying this patch into our app fixes the issue 👍

larouxn
larouxn approved these changes Jun 15, 2023
View reviewed changes
Copy link

@larouxn larouxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely more robust. Thanks for the fix! 👏

@olleolleolle olleolleolle merged commit b54e7ae into main Jun 19, 2023
8 checks passed
@olleolleolle olleolleolle deleted the fix/1509-error-helpers branch June 19, 2023 06:31
@iMacTia
Copy link
Member Author

iMacTia commented Jun 20, 2023

Thank you for merging this @olleolleolle, I'm going to release this as 2.7.7 🎉

@iMacTia iMacTia mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

@brendo brendo brendo approved these changes

@larouxn larouxn larouxn approved these changes

Assignees

@iMacTia iMacTia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Faraday::ParsingError.response_status doesn't return expected value when stubbing response
4 participants
@iMacTia @olleolleolle @brendo @larouxn