Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update minor dependencies (master) #2592

Merged
merged 4 commits into from May 2, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 17, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/container-storage-interface/spec v1.8.0 -> v1.9.0 age adoption passing confidence
github.com/docker/go-connections v0.4.0 -> v0.5.0 age adoption passing confidence
github.com/jinzhu/copier v0.3.5 -> v0.4.0 age adoption passing confidence
github.com/kubernetes-csi/csi-lib-utils v0.6.1 -> v0.17.0 age adoption passing confidence
github.com/prometheus/client_golang v1.17.0 -> v1.19.0 age adoption passing confidence
github.com/stretchr/testify v1.8.4 -> v1.9.0 age adoption passing confidence
golang.org/x/mod v0.14.0 -> v0.16.0 age adoption passing confidence
golang.org/x/time v0.3.0 -> v0.5.0 age adoption passing confidence
k8s.io/api v0.28.6 -> v0.29.3 age adoption passing confidence
k8s.io/api v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/apiextensions-apiserver v0.25.4 -> v0.29.3 age adoption passing confidence
k8s.io/apiextensions-apiserver v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/apimachinery v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/apiserver v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/cli-runtime v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/client-go v0.28.6 -> v0.29.3 age adoption passing confidence
k8s.io/client-go v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/cloud-provider v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/cluster-bootstrap v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/code-generator v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/component-base v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/component-helpers v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/controller-manager v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/cri-api v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/csi-translation-lib v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/dynamic-resource-allocation v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/kms v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/kube-aggregator v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/kube-controller-manager v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/kube-proxy v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/kube-scheduler v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/kubectl v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/kubelet v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/kubernetes v1.28.5 -> v1.29.3 age adoption passing confidence
k8s.io/legacy-cloud-providers v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/metrics v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/mount-utils v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/pod-security-admission v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/sample-apiserver v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/sample-cli-plugin v0.28.5 -> v0.29.3 age adoption passing confidence
k8s.io/sample-controller v0.28.5 -> v0.29.3 age adoption passing confidence
sigs.k8s.io/controller-runtime v0.10.1 -> v0.17.2 age adoption passing confidence

Release Notes

container-storage-interface/spec (github.com/container-storage-interface/spec)

v1.9.0

Compare Source

Breaking changes/Deprecations:

  • None

Additions:

  • spec (PR #​544): [Alpha] Introduce new ControllerModifyVolume RPC and a mutable_parameters field under existing CreateVolumeRequest RPC to enable modification of volume properties (e.g. IOPS, etc.) after volume creation.

Clarifications/Corrections/Fixes:

Dependencies:

  • spec (PR #​550): Updates genproto to use the isolated submodule to reduce overall dependency count and avoids future issues with ambiguous imports.

Full Changelog: container-storage-interface/spec@v1.8.0...v1.9.0

docker/go-connections (github.com/docker/go-connections)

v0.5.0

Compare Source

jinzhu/copier (github.com/jinzhu/copier)

v0.4.0

Compare Source

kubernetes-csi/csi-lib-utils (github.com/kubernetes-csi/csi-lib-utils)

v0.17.0

Compare Source

https://github.com/kubernetes-csi/csi-lib-utils/blob/v0.17.0/CHANGELOG/CHANGELOG-0.17.md

v0.16.0

Compare Source

Changelog

https://github.com/kubernetes-csi/csi-lib-utils/blob/v0.16.0/CHANGELOG/CHANGELOG-0.16.md

v0.15.1

Compare Source

v0.15.0

Compare Source

Changelog

https://github.com/kubernetes-csi/csi-lib-utils/blob/v0.15.0/CHANGELOG/CHANGELOG-0.15.md

v0.14.1

Compare Source

v0.14.0

Compare Source

Changelog

https://github.com/kubernetes-csi/csi-lib-utils/blob/v0.14.0/CHANGELOG/CHANGELOG-0.14.md

v0.13.0

Compare Source

Changelog

https://github.com/kubernetes-csi/csi-lib-utils/blob/v0.13.0/CHANGELOG/CHANGELOG-0.13.md

v0.12.0

Compare Source

Changelog

https://github.com/kubernetes-csi/csi-lib-utils/blob/v0.12.0/CHANGELOG/CHANGELOG-0.12.md

v0.11.0

Compare Source

Changelog

https://github.com/kubernetes-csi/csi-lib-utils/blob/v0.11.0/CHANGELOG/CHANGELOG-0.11.md

v0.10.0

Compare Source

Changelog

https://github.com/kubernetes-csi/csi-lib-utils/blob/v0.10.0/CHANGELOG/CHANGELOG-0.10.md

v0.9.1

Compare Source

Changelog

https://github.com/kubernetes-csi/csi-lib-utils/blob/v0.9.1/CHANGELOG/CHANGELOG-0.9.md

v0.9.0

Compare Source

Changelog

https://github.com/kubernetes-csi/csi-lib-utils/blob/v0.9.0/CHANGELOG/CHANGELOG-0.9.md

v0.8.1

Compare Source

Changelog

https://github.com/kubernetes-csi/csi-lib-utils/blob/v0.8.1/CHANGELOG/CHANGELOG-0.8.md

v0.8.0

Compare Source

Changelog

https://github.com/kubernetes-csi/csi-lib-utils/blob/v0.8.0/CHANGELOG-0.8.md

v0.7.1

Compare Source

Changelog

https://github.com/kubernetes-csi/csi-lib-utils/blob/v0.7.1/CHANGELOG-0.7.md

v0.7.0

Compare Source

Changelog

https://github.com/kubernetes-csi/csi-lib-utils/blob/v0.7.0/CHANGELOG-0.7.md

prometheus/client_golang (github.com/prometheus/client_golang)

v1.19.0

Compare Source

What's Changed

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See https://github.com/prometheus/client_golang/pull/1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

  • [CHANGE] Minimum required go version is now 1.20 (we also test client_golang against new 1.22 version). #​1445 #​1449
  • [FEATURE] collectors: Add version collector. #​1422 #​1427

New Contributors

Full Changelog: prometheus/client_golang@v1.18.0...v1.19.0

v1.18.0

Compare Source

What's Changed

  • [FEATURE] promlint: Allow creation of custom metric validations. #​1311
  • [FEATURE] Go programs using client_golang can be built in wasip1 OS. #​1350
  • [BUGFIX] histograms: Add timer to reset ASAP after bucket limiting has happened. #​1367
  • [BUGFIX] testutil: Fix comparison of metrics with empty Help strings. #​1378
  • [ENHANCEMENT] Improved performance of MetricVec.WithLabelValues(...). #​1360

New Contributors

Full Changelog: prometheus/client_golang@v1.17.0...v1.18.0

stretchr/testify (github.com/stretchr/testify)

v1.9.0

Compare Source

What's Changed

New Contributors


Configuration

📅 Schedule: Branch creation - "after 6pm and before 11pm every weekday,after 10am on saturday,on sunday" in timezone Asia/Taipei, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner February 17, 2024 18:09
@renovate renovate bot force-pushed the renovate/master-minor-dependencies branch 3 times, most recently from 052f3ca to 2f1d65f Compare February 18, 2024 01:27
Copy link

mergify bot commented Feb 18, 2024

This pull request is now in conflict. Could you fix it @renovate[bot]? 🙏

@renovate renovate bot force-pushed the renovate/master-minor-dependencies branch from 2f1d65f to 1f53f3f Compare February 18, 2024 08:39
Copy link

mergify bot commented Feb 18, 2024

This pull request is now in conflict. Could you fix it @renovate[bot]? 🙏

@renovate renovate bot force-pushed the renovate/master-minor-dependencies branch 5 times, most recently from 06d18c7 to 2e31b32 Compare February 19, 2024 04:40
Copy link

mergify bot commented Feb 19, 2024

This pull request is now in conflict. Could you fix it @renovate[bot]? 🙏

@renovate renovate bot force-pushed the renovate/master-minor-dependencies branch 9 times, most recently from 0af92a0 to 7e1f6ca Compare February 23, 2024 04:40
@renovate renovate bot force-pushed the renovate/master-minor-dependencies branch 2 times, most recently from daa8e4b to 3382923 Compare February 27, 2024 10:49
innobead
innobead previously approved these changes Feb 27, 2024
@innobead
Copy link
Member

innobead commented Feb 27, 2024

Need to fix the following error before upgrading the K8s lib dependency to 0.29, as the PSP resource was removed.

datastore/kubernetes.go:842:15: cannot use corev1.ResourceRequirements{…} (value of type "k8s.io/api/core/v1".ResourceRequirements) as "k8s.io/api/core/v1".VolumeResourceRequirements value in struct literal
datastore/kubernetes.go:1018:78: undefined: policyv1beta1.PodSecurityPolicy
datastore/kubernetes.go:1019:38: s.kubeClient.PolicyV1beta1().PodSecurityPolicies undefined (type "k8s.io/client-go/kubernetes/typed/policy/v1beta1".PolicyV1beta1Interface has no field or method PodSecurityPolicies)
datastore/kubernetes.go:1023:71: undefined: policyv1beta1.PodSecurityPolicy
datastore/kubernetes.go:1024:38: s.kubeClient.PolicyV1beta1().PodSecurityPolicies undefined (type "k8s.io/client-go/kubernetes/typed/policy/v1beta1".PolicyV1beta1Interface has no field or method PodSecurityPolicies)
datastore/kubernetes.go:1028:78: undefined: policyv1beta1.PodSecurityPolicy
datastore/kubernetes.go:1029:38: s.kubeClient.PolicyV1beta1().PodSecurityPolicies undefined (type "k8s.io/client-go/kubernetes/typed/policy/v1beta1".PolicyV1beta1Interface has no field or method PodSecurityPolicies)
datastore/uncached.go:197:38: s.kubeClient.PolicyV1beta1().PodSecurityPolicies undefined (type "k8s.io/client-go/kubernetes/typed/policy/v1beta1".PolicyV1beta1Interface has no field or method PodSecurityPolicies)
time="2024-02-27T10:50:27Z" level=fatal msg="exit status 1"

1. Remove `v1beta1.PodSecurityPolicy`.
2. Modify system backup restore controller and unit test cases.
3. Downupgrade package `github.com/prometheus/common` from 0.48.0 to 0.47.0

Signed-off-by: James Lu <james.lu@suse.com>
Copy link
Contributor Author

renovate bot commented Mar 22, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@mantissahz
Copy link
Contributor

@mantissahz mantissahz self-assigned this Mar 25, 2024
Copy link

mergify bot commented Apr 18, 2024

This pull request is now in conflict. Could you fix it @renovate[bot]? 🙏

mergify[bot]
mergify bot previously approved these changes Apr 24, 2024
Copy link

mergify bot commented Apr 24, 2024

This pull request is now in conflict. Could you fix it @renovate[bot]? 🙏

@ejweber
Copy link
Contributor

ejweber commented May 1, 2024

Hello @mantissahz. Sorry in advance for any confusion. @innobead and I were discussing some strangeness around the k8s.io dependencies in longhorn-manager right now and realized that this pending PR was part of it.

To summarize:

  • Renovate tried to update the k8s.io dependencies to v1.29.3 (and v0.29.3) in this PR.
  • That broke PodSecurityPolicy related code, so you fixed it. But we never managed to get the PR reviewed and merged.
  • A different PR (feat: add longhorn/types #2636) actually updated the require directive to v1.29.4 while pinning the version to v1.28.5 with a replace directive (presumably because this PR is necessary to actually move to v1.29.0+).

I added a commit to this branch that:

  • Merges in master.
  • Removes the undesired replace directive.
  • Allows us to actually move to v1.30.0 as Renovate intended.

The code changes you made around PodSecurityPolicy remain untouched. We should get them reviewed and merged ASAP to avoid any further dependency strangeness.

mergify[bot]
mergify bot previously approved these changes May 1, 2024
…or-dependencies

The origin/master branch has already moved beyond k8s.io/kubernetes v1.29.3 to
v1.30.0. Make the required updates to the go.mod file and remove an undesired
replace directive for k8s.io/kubernetes currently in origin/master so that
dependency issues are largely resolved.

Signed-off-by: Eric Weber <eric.weber@suse.com>
@ejweber ejweber force-pushed the renovate/master-minor-dependencies branch from 33ebcf0 to 9d5cba8 Compare May 1, 2024 17:58
Copy link
Contributor

@ejweber ejweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick issue to fix.

In general, I think we should follow this up with an issue around system backup and restore behavior as it pertains to PodSecurityPolicies, Roles, and RoleBindings. (I prefer we handle it in a followup so we can get Renovate back on track with its dependency updates.)

controller/system_backup_controller.go Show resolved Hide resolved
csi/controller_server.go Outdated Show resolved Hide resolved
mergify[bot]
mergify bot previously approved these changes May 1, 2024
Signed-off-by: James Lu <james.lu@suse.com>
Copy link
Contributor

@ejweber ejweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ejweber ejweber merged commit 884ba76 into master May 2, 2024
8 of 9 checks passed
@ejweber ejweber deleted the renovate/master-minor-dependencies branch May 2, 2024 14:11
@ejweber
Copy link
Contributor

ejweber commented May 2, 2024

Merged this one to unblock Renovate. Let's follow up in longhorn/longhorn#8056 with any additional concerns around changes to system backup functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants