Fix failed non-required checks failing overarching command

[Green-Ranger11]

This closes #44

If checks are not required then pull request should be mergable given the other statuses pass.
Failed checks in yellow are non-required.
Failed checks in red are required.

Which means you can get output where you can merge even though non-required checks failed.

[Green-Ranger11]

I'm going to fix the tests and try and take out the re-request logic from filterPullRequest

[ljharb]

Suggested change

	if (requiredChecks) {
	if (requiredChecks.includes(node.name)) {
	failure.push({ name: node.name, isRequired: true });
	} else {
	failure.push({ name: node.name, isRequired: false });
	}
	} else if (node.isRequired) {
	failure.push({ name: node.name, isRequired: true });
	} else {
	failure.push({ name: node.name, isRequired: false });
	}
	failure.push({
	name: node.name,
	isRequired: requiredChecks?.includes(node.name) ?? !!node.isRequired,
	});

[Green-Ranger11]

This is extremely way more elegant and will make the change

[Green-Ranger11]

[ljharb]

maybe we could indent (or add -) to the listed checks, so it's more clear what's the heading and what's the list?

also the color is nice, but it'd be great to avoid relying solely on color for conveying information (some people are colorblind), can we add a padlock in front of the required ones maybe?

[Green-Ranger11]

Ah yes those are all great points and will do that shortly!

[Green-Ranger11]

[ljharb]

Sounds good - altho if the padlock is there, maybe we don't need the hyphens; we can just use spaces to indent?

[Green-Ranger11]

Sure! Will just add the space instead because the unlocked padlock icon doesn't really match as it looks exactly like this 🔓 but the locked padlock looks exactly as is in terminal and matches all the other emojis.

[Green-Ranger11]

[Green-Ranger11]

[Green-Ranger11]

Just double checking but do the checks align up on your terminal? This may look different on other terminals which is something i have not tested.
If this pr can wait I can try it out on various terminals with different fonts.

[ljharb]

i'll check next time i have a pending PR :-p

[ljharb]

Seems pretty good - i'll check on a couple others to be sure.