Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing trait hooks #8268

Merged
merged 4 commits into from
Apr 6, 2024
Merged

Missing trait hooks #8268

merged 4 commits into from
Apr 6, 2024

Conversation

AlexandreBonaventure
Copy link
Contributor

Follow up on this one: #8215

@calebporzio
Copy link
Collaborator

Thank you for finishing this up @AlexandreBonaventure !

@calebporzio calebporzio merged commit 1c8ae8b into livewire:main Apr 6, 2024
5 checks passed
@francoism90
Copy link
Contributor

francoism90 commented May 6, 2024 •
edited

@AlexandreBonaventure Just an question about this commit, hope that's ok. :)

Is it also possible to add the exception inside the trait as well (e.g. WithPost => exceptionWithPost(..)), as can be seen in the examples later? I was thinking about catching model exceptions like 403/404, and than redirect to /<-response-code>.

@AlexandreBonaventure
Copy link
Contributor Author

@francoism90, sure that should work!

@francoism90
Copy link
Contributor

@AlexandreBonaventure that's awesome! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexandreBonaventure @calebporzio @francoism90