Fixed undefined key with unset method of DataStore #8231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a new exception today after upgrading my app to the latest version.
The exception is
Undefined array key "computedProperties"
which I was able to trace back to #8048 and that there needed to be anotherisset()
check on the$key
.The issue I was able to replicate that this fixes is with a legacy computed property (ex:
getUserProperty()
) which is using an event attributeex: [On('someEvent')]
and I guess it isn't in the data store for that kind of flow.I updated the test added in #8048 and without the change I've made would fail, but continues to pass with the change, supporting both cases.