Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command enhancement for livewire:make using Laravel Prompts #6770

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

PhiloNL
Copy link
Collaborator

@PhiloNL PhiloNL commented Sep 11, 2023

The first step towards implementing Laravel Prompts. If you run php artisan livewire:make without any arguments it will prompt for the various options.

image

@utsavsomaiya
Copy link
Contributor

utsavsomaiya commented Sep 12, 2023

I think this code shouldn't be maintainable because there is multiple scenario are covered!!

  1. For first livewire installed user to display the livewire logo and open the github repo...
  2. Other we need to use the stub files and validate it and then we create it!!

So can we create as laravel does? e.g. : https://github.com/laravel/installer/blob/master/src/NewCommand.php

@PhiloNL
Copy link
Collaborator Author

PhiloNL commented Sep 12, 2023

I think this code shouldn't be maintainable because there is multiple scenario are covered!!

  1. For first livewire installed user to display the livewire logo and open the github repo...

  2. Other we need to use the stub files and validate it and then we create it!!


So can we create as laravel does? e.g. : https://github.com/laravel/installer/blob/master/src/NewCommand.php

Sorry I don't follow. This PR is just an enhancement that will prompt for input if you don't provide any arguments instead of throwing an error.

@calebporzio
Copy link
Collaborator

Awesome, thanks Philo!

@calebporzio calebporzio merged commit c711654 into livewire:main Sep 12, 2023
1 of 2 checks passed
calebporzio added a commit that referenced this pull request Sep 12, 2023
calebporzio added a commit that referenced this pull request Sep 12, 2023
calebporzio added a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants