Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Cleanup #5785

Merged
merged 16 commits into from Jul 21, 2023
Merged

[v3] Cleanup #5785

merged 16 commits into from Jul 21, 2023

Conversation

nuernbergerA
Copy link
Contributor

if tried to change as less as possible

Support only Flysystem v3+

  • Livewire 3 requires Laravel >= 9 which supports only Flysystem >= 3

Findings

  • \Livewire\Drawer\BaseUtils::propertyHasAnnotation()
    • unused
  • \Livewire\Drawer\CompilerEngineForIgnition
    • unused with deadcode
  • \Livewire\Drawer\Regexes
    • only $livewireOpeningTagOrSelfClosingTag used
    • all other properties are unused
  • \Livewire\Drawer\Utils::anonymousClassToStringClass()
    • unused
  • \Livewire\Exceptions\CannotUseReservedLivewireComponentProperties
    • unused
  • \Livewire\Exceptions\PublicPropertyTypeNotAllowedException
    • unused
  • \Livewire\Features\SupportAttributes\SupportAttributes::update()
    • $propertyName passed but never used
    • \Livewire\Features\SupportLifecycleHooks\update() has the same signature
      • ignores $propertyName and overwrites it with $fullPath
  • \Livewire\Features\SupportErrorResponses\SupportErrorResponses
    • unused
  • \Livewire\Features\SupportJavaScriptOrderedArrays\SupportJavaScriptOrderedArrays
    • unused
  • \Livewire\Mechanisms\HandleComponents\Synthesizers\CarbonSynth::dehydrate()
    • $target->format(DateTimeInterface::ISO8601) deprecation warning
      • Use DateTime::ATOM or DATE_ATOM for compatibility with ISO-8601 instead
  • \Livewire\Mechanisms\HandleComponents\ComponentContext
    • #[AllowDynamicProperties] - This in a PHP 8.2 feature
  • \Livewire\CoreMixin
    • unsued
  • \Livewire\OnlyDuringTests
    • unsued

Commands

needs better structure (separate commands from util classes)

  • \Livewire\Features\SupportConsoleCommands\Commands\FileManipulationCommand
    • should be abstract
  • \Livewire\Features\SupportConsoleCommands\Commands
    • unused

@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livewire ❌ Failed (Inspect) Jul 20, 2023 8:01pm

@joshhanley joshhanley merged commit 0429829 into livewire:master Jul 21, 2023
4 checks passed
@joshhanley
Copy link
Member

Thanks!

@nuernbergerA nuernbergerA deleted the cleanup branch July 21, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants