build: configure type checkers to run on min supported version #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR modifies our type-checking to run on the minimum supported version, instead of the latest. Rationale: - Reduce incidence of backward incompatible changes. - Improve local development workflow - prior to this change, local development requires 2 python environments, 1 for 3.8 for dev/running tests, and one for 3.12 to run the type checkers. After this change developers will only have to run a single python environment for running both tests and type-checks.
peterschutt
commented
Oct 20, 2023
peterschutt
force-pushed
the
type-check-on-3.8
branch
from
3d161de
to
7329c03
Compare
guacs
approved these changes
Oct 20, 2023
JacobCoffee
reviewed
Oct 20, 2023
JacobCoffee
approved these changes
Oct 20, 2023
sobolevn
reviewed
Oct 20, 2023
Sorry @JacobCoffee can you clarify the question please? |
In |
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
Kudos, SonarCloud Quality Gate passed! |
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
This PR modifies our type-checking to run on the minimum supported version, instead of the latest.
Rationale:
Close Issue(s)