Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lit-starter-js] [lit-starter-ts] Update starter template READMEs #4630

Conversation

pixelbandito
Copy link
Contributor

  • Change github pages branch name from "master" to "main"
  • Change npm run docs:watch to npm run docs:gen:watch

Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: 0c3c7e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

google-cla bot commented Apr 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pixelbandito pixelbandito force-pushed the lit-starter-js-ts-fix-readme-branch-name-and-docs-gen-build branch from bb86e86 to 1a21cf0 Compare April 25, 2024 04:52
@pixelbandito pixelbandito force-pushed the lit-starter-js-ts-fix-readme-branch-name-and-docs-gen-build branch from 1a21cf0 to 43fa3a4 Compare April 26, 2024 13:36
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Could you run npx changeset --empty from project root and commit the empty file for CI? I would do it myself but you don't have the maintainers are allowed to make edits to PR enabled.

@pixelbandito
Copy link
Contributor Author

@augustjk Done - that look ok?

@augustjk
Copy link
Member

Awesome, thanks!

@augustjk augustjk merged commit 3d5f473 into lit:main May 31, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants