-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lit/context] Use target.set
for setting context values
#4598
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 39f9a1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📊 Tachometer Benchmark ResultsSummary⏳ Benchmarks are currently running. Results below are out of date. nop-update
render
update
update-reflect
Results⏳ Benchmarks are currently running. Results below are out of date. this-change
render
update
update-reflect
this-change, tip-of-tree, previous-release
render
update
nop-update
this-change, tip-of-tree, previous-release
render
update
this-change, tip-of-tree, previous-release
render
update
update-reflect
|
The size of lit-html.js and lit-core.min.js are as expected. |
a96bd95
to
d12c192
Compare
access.set
for setting context valuestarget.set
for setting context values
d12c192
to
9f379a2
Compare
Thanks @jun-sheaf! We need a changeset file as part of the PR. See https://github.com/lit/lit/blob/main/CONTRIBUTING.md#pull-requests |
8b18d66
to
25a2aae
Compare
Done. |
25a2aae
to
8f1ced4
Compare
8f1ced4
to
a3ef61a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
`target.set` is the correct way to set values in decorators. It supports nested decorators and private fields.
Co-authored-by: Augustine Kim <ajk830@gmail.com>
1f033f9
to
39f9a1e
Compare
target.set
is the correct way to set values in decorators. It supports nested decorators and private fields.