[labs/ssr-dom-shim] Patch localName and tagName with customElements.define call #4553
Conversation
🦋 Changeset detectedLatest commit: 4c2fe5b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
kyubisation
changed the title
kyubisation
force-pushed
the
fix-ssr-local-name
branch
from
e1dffa7
to
1896c91
Compare
…lements.define call This change extends the CustomElementRegistryShim to patch localName and tagName into the web component, when calling define. This allows instances to call `this.localName` and `this.tagName` accordingly. Fixes lit#3375
kyubisation
force-pushed
the
fix-ssr-local-name
branch
from
1896c91
to
4ed2986
Compare
|
Sorry, I missed the section in |
| @@ -148,6 +148,17 @@ const CustomElementRegistryShim = class CustomElementRegistry { | |||
| ); | |||
| } | |||
| } | |||
| // Polyfill tagName and localName for the component. | |||
| Object.defineProperties(ctor.prototype, { | |||
There was a problem hiding this comment.
Instead of patching the prototype, which could theoretically have overridden these getters, I think they should be defined on the Element shim above with the other Element methods.
Here the registry can set an internal property of the element to the registry, either like ctor.__registry = this, or ctor.__localName = name to use in the getters.
There was a problem hiding this comment.
I have adapted the code with __localName.
Feel free to have another look. If you have any other suggestion, I will improve the PR as desired.
…customElements.define call
This change extends the CustomElementRegistryShim to patch localName and tagName into the web component, when calling define.
This allows instances to call
this.localNameandthis.tagNameaccordingly.Fixes #3375