[infra] Add browser export conditions to package.json

[AndrewJakubowicz]

Fixes: #4446

Context

This is a compromise so that testing in Vitest works. As part of this work I explored simplifying the package.json exports using subpath patterns. Unfortunately the ecosystem doesn't support those very well, so it's been punted.

• First commit contains the script.
• Second commit contains the result of running the script.

Marked this a patch change, as it's a minor "bug fix" workaround for testing in Jest and Vitest.

This script has two modes:

• test: won't write any files, but instead checks that no files need to be fixed. Is run as part of our CI.
• fix: writes to package.json files.

Test plan

The prior browser/node entrypoints are tested via our CI.

The script itself is lightly tested via node assertions. The script won't run if an assertion fails.

Risk

This changes the entrypoints in some of our package.json configurations, so it is a slightly risky change. We've manually verified that adding the browser export above node works correctly. Similarly if our test suite passes, then this should not be a regression as we use the exports in our tests.

[changeset-bot]

🦋 Changeset detected

Latest commit: 07e1f9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@lit/reactive-element	Patch
@lit-labs/ssr-client	Patch
@lit-labs/react	Patch
lit-html	Patch
@lit/react	Patch
lit-element	Patch
lit	Patch
@lit-internal/test-elements-react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

📊 Tachometer Benchmark Results

Summary

nop-update

• this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +9% (-0.36ms - +1.00ms)
  ^{this-change vs tip-of-tree}

render

• this-change: 47.15ms - 49.37ms
• this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +6% (-0.32ms - +1.09ms)
  ^{this-change vs tip-of-tree}
• this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.61ms - +0.63ms)
  ^{this-change vs tip-of-tree}
• this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +3% (-0.14ms - +0.99ms)
  ^{this-change vs tip-of-tree}

update

• this-change: 511.07ms - 518.62ms
• this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +8% (-1.69ms - +3.18ms)
  ^{this-change vs tip-of-tree}
• this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-0.83ms - +1.35ms)
  ^{this-change vs tip-of-tree}
• this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-2.85ms - +3.28ms)
  ^{this-change vs tip-of-tree}

update-reflect

• this-change: 513.66ms - 518.66ms
• this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +1% (-1.59ms - +4.30ms)
  ^{this-change vs tip-of-tree}

Results

this-change

• Browser: chrome-headless 120.0.6099.199
• Sample size: 50
• Built by: Benchmarks #5997

• Commit: 07e1f9a

render

Version	Avg time	vs
	47.15ms - 49.37ms	-

update

Version	Avg time	vs
	511.07ms - 518.62ms	-

update-reflect

Version	Avg time	vs
	513.66ms - 518.66ms	-

this-change, tip-of-tree, previous-release

• Browser: chrome-headless 120.0.6099.199
• Sample size: 30
• Built by: Benchmarks #5997

• Commit: 07e1f9a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	18.70ms - 19.79ms	-	unsure 🔍 -2% - +6% -0.32ms - +1.09ms	unsure 🔍 -1% - +7% -0.23ms - +1.22ms
tip-of-tree tip-of-tree	18.41ms - 19.30ms	unsure 🔍 -6% - +2% -1.09ms - +0.32ms	-	unsure 🔍 -3% - +4% -0.54ms - +0.76ms
previous-release previous-release	18.27ms - 19.22ms	unsure 🔍 -6% - +1% -1.22ms - +0.23ms	unsure 🔍 -4% - +3% -0.76ms - +0.54ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	39.06ms - 42.56ms	-	unsure 🔍 -4% - +8% -1.69ms - +3.18ms	unsure 🔍 -6% - +7% -2.35ms - +2.70ms
tip-of-tree tip-of-tree	38.36ms - 41.76ms	unsure 🔍 -8% - +4% -3.18ms - +1.69ms	-	unsure 🔍 -8% - +5% -3.07ms - +1.92ms
previous-release previous-release	38.81ms - 42.46ms	unsure 🔍 -7% - +6% -2.70ms - +2.35ms	unsure 🔍 -5% - +8% -1.92ms - +3.07ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.22ms - 12.15ms	-	unsure 🔍 -3% - +9% -0.36ms - +1.00ms	unsure 🔍 -3% - +7% -0.39ms - +0.80ms
tip-of-tree tip-of-tree	10.87ms - 11.86ms	unsure 🔍 -8% - +3% -1.00ms - +0.36ms	-	unsure 🔍 -6% - +4% -0.74ms - +0.50ms
previous-release previous-release	11.11ms - 11.85ms	unsure 🔍 -7% - +3% -0.80ms - +0.39ms	unsure 🔍 -4% - +7% -0.50ms - +0.74ms	-

this-change, tip-of-tree, previous-release

• Browser: chrome-headless 120.0.6099.199
• Sample size: 50
• Built by: Benchmarks #5997

• Commit: 07e1f9a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	33.19ms - 34.07ms	-	unsure 🔍 -2% - +2% -0.61ms - +0.63ms	unsure 🔍 -4% - +2% -1.34ms - +0.61ms
tip-of-tree tip-of-tree	33.19ms - 34.05ms	unsure 🔍 -2% - +2% -0.63ms - +0.61ms	-	unsure 🔍 -4% - +2% -1.35ms - +0.60ms
previous-release previous-release	33.12ms - 34.87ms	unsure 🔍 -2% - +4% -0.61ms - +1.34ms	unsure 🔍 -2% - +4% -0.60ms - +1.35ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	69.18ms - 70.78ms	-	unsure 🔍 -1% - +2% -0.83ms - +1.35ms	unsure 🔍 -1% - +2% -0.80ms - +1.33ms
tip-of-tree tip-of-tree	68.98ms - 70.46ms	unsure 🔍 -2% - +1% -1.35ms - +0.83ms	-	unsure 🔍 -1% - +1% -1.02ms - +1.03ms
previous-release previous-release	69.00ms - 70.42ms	unsure 🔍 -2% - +1% -1.33ms - +0.80ms	unsure 🔍 -1% - +1% -1.03ms - +1.02ms	-

this-change, tip-of-tree, previous-release

• Browser: chrome-headless 120.0.6099.199
• Sample size: 50
• Built by: Benchmarks #5997

• Commit: 07e1f9a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	33.73ms - 34.58ms	-	unsure 🔍 -0% - +3% -0.14ms - +0.99ms	unsure 🔍 -2% - +2% -0.63ms - +0.53ms
tip-of-tree tip-of-tree	33.36ms - 34.10ms	unsure 🔍 -3% - +0% -0.99ms - +0.14ms	-	unsure 🔍 -3% - +0% -1.02ms - +0.06ms
previous-release previous-release	33.82ms - 34.60ms	unsure 🔍 -2% - +2% -0.53ms - +0.63ms	unsure 🔍 -0% - +3% -0.06ms - +1.02ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	521.87ms - 526.04ms	-	unsure 🔍 -1% - +1% -2.85ms - +3.28ms	unsure 🔍 -1% - +1% -3.22ms - +2.74ms
tip-of-tree tip-of-tree	521.49ms - 525.99ms	unsure 🔍 -1% - +1% -3.28ms - +2.85ms	-	unsure 🔍 -1% - +1% -3.55ms - +2.64ms
previous-release previous-release	522.07ms - 526.32ms	unsure 🔍 -1% - +1% -2.74ms - +3.22ms	unsure 🔍 -1% - +1% -2.64ms - +3.55ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	529.60ms - 533.84ms	-	unsure 🔍 -0% - +1% -1.59ms - +4.30ms	unsure 🔍 -1% - +1% -3.93ms - +3.84ms
tip-of-tree tip-of-tree	528.32ms - 532.41ms	unsure 🔍 -1% - +0% -4.30ms - +1.59ms	-	unsure 🔍 -1% - +0% -5.25ms - +2.44ms
previous-release previous-release	528.52ms - 535.02ms	unsure 🔍 -1% - +1% -3.84ms - +3.93ms	unsure 🔍 -0% - +1% -2.44ms - +5.25ms	-

_{tachometer-reporter-action v2 for Benchmarks}

[github-actions]

The size of lit-html.js and lit-core.min.js are as expected.

[rictic]

This is great work!