Remove unused internal parameters to requestUpdate

[justinfagnani]

I noticed this while re-reading some of the code. This was for distinguishing initial values while we were still trying to not reflect initial values for standard decorators.

[changeset-bot]

🦋 Changeset detected

Latest commit: 81310e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@lit/reactive-element	Patch
lit-element	Patch
lit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

📊 Tachometer Benchmark Results

Summary

nop-update

• this-change, tip-of-tree, previous-release: unsure 🔍 -9% - +0% (-1.03ms - +0.07ms)
  ^{this-change vs tip-of-tree}

render

• this-change: 47.63ms - 50.01ms
• this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +5% (-0.59ms - +1.01ms)
  ^{this-change vs tip-of-tree}
• this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.48ms - +1.00ms)
  ^{this-change vs tip-of-tree}
• this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.62ms - +0.60ms)
  ^{this-change vs tip-of-tree}

update

• this-change: 499.22ms - 504.28ms
• this-change, tip-of-tree, previous-release: unsure 🔍 -11% - +2% (-4.40ms - +0.82ms)
  ^{this-change vs tip-of-tree}
• this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-1.41ms - +1.05ms)
  ^{this-change vs tip-of-tree}
• this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +1% (-2.41ms - +4.16ms)
  ^{this-change vs tip-of-tree}

update-reflect

• this-change: 499.26ms - 502.88ms
• this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +0% (-4.51ms - +1.01ms)
  ^{this-change vs tip-of-tree}

Results

this-change

• Browser: chrome-headless 119.0.6045.159
• Sample size: 50
• Built by: Benchmarks #5914

• Commit: 81310e8

render

Version	Avg time	vs
	47.63ms - 50.01ms	-

update

Version	Avg time	vs
	499.22ms - 504.28ms	-

update-reflect

Version	Avg time	vs
	499.26ms - 502.88ms	-

this-change, tip-of-tree, previous-release

• Browser: chrome-headless 119.0.6045.159
• Sample size: 30
• Built by: Benchmarks #5914

• Commit: 81310e8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	18.40ms - 19.53ms	-	unsure 🔍 -3% - +5% -0.59ms - +1.01ms	unsure 🔍 -6% - +2% -1.14ms - +0.45ms
tip-of-tree tip-of-tree	18.19ms - 19.33ms	unsure 🔍 -5% - +3% -1.01ms - +0.59ms	-	unsure 🔍 -7% - +1% -1.35ms - +0.25ms
previous-release previous-release	18.75ms - 19.87ms	unsure 🔍 -2% - +6% -0.45ms - +1.14ms	unsure 🔍 -1% - +7% -0.25ms - +1.35ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	37.47ms - 41.11ms	-	unsure 🔍 -11% - +2% -4.40ms - +0.82ms	unsure 🔍 -11% - +1% -4.74ms - +0.54ms
tip-of-tree tip-of-tree	39.21ms - 42.94ms	unsure 🔍 -2% - +11% -0.82ms - +4.40ms	-	unsure 🔍 -7% - +6% -2.98ms - +2.36ms
previous-release previous-release	39.48ms - 43.29ms	unsure 🔍 -2% - +12% -0.54ms - +4.74ms	unsure 🔍 -6% - +7% -2.36ms - +2.98ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	10.72ms - 11.54ms	-	unsure 🔍 -9% - +0% -1.03ms - +0.07ms	unsure 🔍 -7% - +3% -0.83ms - +0.31ms
tip-of-tree tip-of-tree	11.24ms - 11.98ms	unsure 🔍 -1% - +9% -0.07ms - +1.03ms	-	unsure 🔍 -3% - +7% -0.33ms - +0.77ms
previous-release previous-release	10.98ms - 11.80ms	unsure 🔍 -3% - +8% -0.31ms - +0.83ms	unsure 🔍 -7% - +3% -0.77ms - +0.33ms	-

this-change, tip-of-tree, previous-release

• Browser: chrome-headless 119.0.6045.159
• Sample size: 50
• Built by: Benchmarks #5914

• Commit: 81310e8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	34.10ms - 35.18ms	-	unsure 🔍 -1% - +3% -0.48ms - +1.00ms	unsure 🔍 -1% - +3% -0.28ms - +1.16ms
tip-of-tree tip-of-tree	33.87ms - 34.88ms	unsure 🔍 -3% - +1% -1.00ms - +0.48ms	-	unsure 🔍 -1% - +3% -0.51ms - +0.87ms
previous-release previous-release	33.73ms - 34.67ms	unsure 🔍 -3% - +1% -1.16ms - +0.28ms	unsure 🔍 -3% - +1% -0.87ms - +0.51ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	68.85ms - 70.29ms	-	unsure 🔍 -2% - +2% -1.41ms - +1.05ms	unsure 🔍 -1% - +2% -0.59ms - +1.43ms
tip-of-tree tip-of-tree	68.75ms - 70.74ms	unsure 🔍 -2% - +2% -1.05ms - +1.41ms	-	unsure 🔍 -1% - +3% -0.63ms - +1.83ms
previous-release previous-release	68.44ms - 69.86ms	unsure 🔍 -2% - +1% -1.43ms - +0.59ms	unsure 🔍 -3% - +1% -1.83ms - +0.63ms	-

this-change, tip-of-tree, previous-release

• Browser: chrome-headless 119.0.6045.159
• Sample size: 50
• Built by: Benchmarks #5914

• Commit: 81310e8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	32.58ms - 33.43ms	-	unsure 🔍 -2% - +2% -0.62ms - +0.60ms	unsure 🔍 -2% - +1% -0.77ms - +0.39ms
tip-of-tree tip-of-tree	32.57ms - 33.46ms	unsure 🔍 -2% - +2% -0.60ms - +0.62ms	-	unsure 🔍 -2% - +1% -0.78ms - +0.42ms
previous-release previous-release	32.79ms - 33.60ms	unsure 🔍 -1% - +2% -0.39ms - +0.77ms	unsure 🔍 -1% - +2% -0.42ms - +0.78ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	505.73ms - 511.12ms	-	unsure 🔍 -0% - +1% -2.41ms - +4.16ms	unsure 🔍 -1% - +1% -2.79ms - +4.38ms
tip-of-tree tip-of-tree	505.67ms - 509.42ms	unsure 🔍 -1% - +0% -4.16ms - +2.41ms	-	unsure 🔍 -1% - +1% -3.10ms - +2.94ms
previous-release previous-release	505.27ms - 509.99ms	unsure 🔍 -1% - +1% -4.38ms - +2.79ms	unsure 🔍 -1% - +1% -2.94ms - +3.10ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	510.46ms - 513.54ms	-	unsure 🔍 -1% - +0% -4.51ms - +1.01ms	unsure 🔍 -1% - +0% -3.12ms - +1.42ms
tip-of-tree tip-of-tree	511.46ms - 516.05ms	unsure 🔍 -0% - +1% -1.01ms - +4.51ms	-	unsure 🔍 -0% - +1% -1.94ms - +3.74ms
previous-release previous-release	511.18ms - 514.52ms	unsure 🔍 -0% - +1% -1.42ms - +3.12ms	unsure 🔍 -1% - +0% -3.74ms - +1.94ms	-

_{tachometer-reporter-action v2 for Benchmarks}

[github-actions]

The size of lit-html.js and lit-core.min.js are as expected.

[AndrewJakubowicz]

LGTM!

Thank you. Just need to update the size and changeset!

[AndrewJakubowicz]

I addressed code review feedback on changeset and Lit expected size.
There was a minor GitHub outage that blocked Actions from running so I created an empty commit to kickstart the actions.
Once they pass I'll merge.