Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lit-html] Fix styleMap initial render of mixed-case custom props #3766

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

justinfagnani
Copy link
Collaborator

Fixes #3738

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

🦋 Changeset detected

Latest commit: adccf82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
lit-html Patch
lit Patch
lit-element Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -3% - +6% (-0.62ms - +1.32ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 112.08ms - 117.84ms
  • lit-html-kitchen-sink: unsure 🔍 -5% - +8% (-2.09ms - +3.40ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -6% - +7% (-0.78ms - +0.92ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +1% (-2.10ms - +1.15ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +3% (-1.00ms - +2.39ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 1191.31ms - 1207.45ms
  • lit-html-kitchen-sink: unsure 🔍 -0% - +7% (-0.04ms - +7.45ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +2% (-8.24ms - +7.40ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +1% (-2.79ms - +1.80ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-8.08ms - +8.51ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 1166.75ms - 1178.09ms
  • reactive-element-list: unsure 🔍 -0% - +1% (-2.55ms - +13.27ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
112.08ms - 117.84ms-

update

VersionAvg timevs
1191.31ms - 1207.45ms-

update-reflect

VersionAvg timevs
1166.75ms - 1178.09ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
43.53ms - 47.89ms-unsure 🔍
-5% - +8%
-2.09ms - +3.40ms
unsure 🔍
-5% - +9%
-2.14ms - +4.08ms
tip-of-tree
tip-of-tree
43.39ms - 46.71msunsure 🔍
-7% - +5%
-3.40ms - +2.09ms
-unsure 🔍
-6% - +7%
-2.45ms - +3.08ms
previous-release
previous-release
42.53ms - 46.95msunsure 🔍
-9% - +5%
-4.08ms - +2.14ms
unsure 🔍
-7% - +5%
-3.08ms - +2.45ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
112.11ms - 117.86ms-unsure 🔍
-0% - +7%
-0.04ms - +7.45ms
unsure 🔍
-3% - +4%
-3.17ms - +5.01ms
tip-of-tree
tip-of-tree
108.88ms - 113.68msunsure 🔍
-6% - -0%
-7.45ms - +0.04ms
-unsure 🔍
-6% - +1%
-6.55ms - +0.98ms
previous-release
previous-release
111.16ms - 116.97msunsure 🔍
-4% - +3%
-5.01ms - +3.17ms
unsure 🔍
-1% - +6%
-0.98ms - +6.55ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
21.07ms - 22.72ms-unsure 🔍
-3% - +6%
-0.62ms - +1.32ms
unsure 🔍
-20% - +6%
-4.79ms - +1.63ms
tip-of-tree
tip-of-tree
21.03ms - 22.06msunsure 🔍
-6% - +3%
-1.32ms - +0.62ms
-unsure 🔍
-21% - +4%
-5.07ms - +1.22ms
previous-release
previous-release
20.37ms - 26.57msunsure 🔍
-8% - +22%
-1.63ms - +4.79ms
unsure 🔍
-6% - +24%
-1.22ms - +5.07ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
13.54ms - 14.64ms-unsure 🔍
-6% - +7%
-0.78ms - +0.92ms
unsure 🔍
-5% - +9%
-0.71ms - +1.18ms
tip-of-tree
tip-of-tree
13.37ms - 14.66msunsure 🔍
-7% - +6%
-0.92ms - +0.78ms
-unsure 🔍
-6% - +8%
-0.84ms - +1.16ms
previous-release
previous-release
13.10ms - 14.62msunsure 🔍
-8% - +5%
-1.18ms - +0.71ms
unsure 🔍
-8% - +6%
-1.16ms - +0.84ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
353.18ms - 361.36ms-unsure 🔍
-2% - +2%
-8.24ms - +7.40ms
unsure 🔍
-4% - +0%
-14.66ms - +0.21ms
tip-of-tree
tip-of-tree
351.02ms - 364.35msunsure 🔍
-2% - +2%
-7.40ms - +8.24ms
-unsure 🔍
-4% - +1%
-15.91ms - +2.31ms
previous-release
previous-release
358.28ms - 370.70msunsure 🔍
-0% - +4%
-0.21ms - +14.66ms
unsure 🔍
-1% - +4%
-2.31ms - +15.91ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
74.94ms - 77.01ms-unsure 🔍
-3% - +1%
-2.10ms - +1.15ms
unsure 🔍
-3% - +1%
-2.23ms - +0.58ms
tip-of-tree
tip-of-tree
75.20ms - 77.70msunsure 🔍
-2% - +3%
-1.15ms - +2.10ms
-unsure 🔍
-2% - +2%
-1.92ms - +1.22ms
previous-release
previous-release
75.85ms - 77.75msunsure 🔍
-1% - +3%
-0.58ms - +2.23ms
unsure 🔍
-2% - +3%
-1.22ms - +1.92ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
168.40ms - 171.55ms-unsure 🔍
-2% - +1%
-2.79ms - +1.80ms
unsure 🔍
-2% - +1%
-3.14ms - +1.94ms
tip-of-tree
tip-of-tree
168.79ms - 172.15msunsure 🔍
-1% - +2%
-1.80ms - +2.79ms
-unsure 🔍
-2% - +1%
-2.71ms - +2.51ms
previous-release
previous-release
168.58ms - 172.56msunsure 🔍
-1% - +2%
-1.94ms - +3.14ms
unsure 🔍
-1% - +2%
-2.51ms - +2.71ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
75.44ms - 77.75ms-unsure 🔍
-1% - +3%
-1.00ms - +2.39ms
slower ❌
0% - 4%
0.06ms - 3.07ms
tip-of-tree
tip-of-tree
74.66ms - 77.15msunsure 🔍
-3% - +1%
-2.39ms - +1.00ms
-unsure 🔍
-1% - +3%
-0.71ms - +2.45ms
previous-release
previous-release
74.07ms - 76.00msfaster ✔
0% - 4%
0.06ms - 3.07ms
unsure 🔍
-3% - +1%
-2.45ms - +0.71ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1228.37ms - 1238.57ms-unsure 🔍
-1% - +1%
-8.08ms - +8.51ms
unsure 🔍
-0% - +1%
-3.71ms - +11.71ms
tip-of-tree
tip-of-tree
1226.72ms - 1239.80msunsure 🔍
-1% - +1%
-8.51ms - +8.08ms
-unsure 🔍
-0% - +1%
-4.94ms - +12.52ms
previous-release
previous-release
1223.69ms - 1235.25msunsure 🔍
-1% - +0%
-11.71ms - +3.71ms
unsure 🔍
-1% - +0%
-12.52ms - +4.94ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1227.32ms - 1237.45ms-unsure 🔍
-0% - +1%
-2.55ms - +13.27ms
slower ❌
0% - 1%
2.59ms - 17.65ms
tip-of-tree
tip-of-tree
1220.95ms - 1233.10msunsure 🔍
-1% - +0%
-13.27ms - +2.55ms
-unsure 🔍
-0% - +1%
-3.49ms - +13.00ms
previous-release
previous-release
1216.70ms - 1227.84msfaster ✔
0% - 1%
2.59ms - 17.65ms
unsure 🔍
-1% - +0%
-13.00ms - +3.49ms
-

tachometer-reporter-action v2 for Benchmarks

@justinfagnani justinfagnani changed the title Fix styleMap initial render of mixed-case custom props [lit-html] Fix styleMap initial render of mixed-case custom props Mar 28, 2023
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sorvell sorvell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@justinfagnani justinfagnani merged commit 4431cbb into main Apr 13, 2023
6 of 7 checks passed
@justinfagnani justinfagnani deleted the style-map-casing branch April 13, 2023 19:59
@lit-robot lit-robot mentioned this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lit-html] styleMap does not work with camel cased custom properties.
3 participants