New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[labs/ssr-dom-shim] Add basic support for element internals #3677
Merged
augustjk
merged 16 commits into
lit:main
from
calebdwilliams:feat/ssr-dom-shim-internals
Mar 21, 2023
Merged
[labs/ssr-dom-shim] Add basic support for element internals #3677
augustjk
merged 16 commits into
lit:main
from
calebdwilliams:feat/ssr-dom-shim-internals
Mar 21, 2023
Commits on Mar 11, 2023
-
[labs/ssr-dom-shim] Add basic support for element internals
* Add a rough implementation for ElementShim.prototype.attachInternals Fixes lit#3676
Configuration menu - View commit details
-
Copy full SHA for cba3c95 - Browse repository at this point
Copy the full SHA cba3c95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49b7387 - Browse repository at this point
Copy the full SHA 49b7387View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbaa901 - Browse repository at this point
Copy the full SHA fbaa901View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3684584 - Browse repository at this point
Copy the full SHA 3684584View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94a1b81 - Browse repository at this point
Copy the full SHA 94a1b81View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1d6b27 - Browse repository at this point
Copy the full SHA c1d6b27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d9d094 - Browse repository at this point
Copy the full SHA 2d9d094View commit details -
Configuration menu - View commit details
-
Copy full SHA for f138ee6 - Browse repository at this point
Copy the full SHA f138ee6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8f93cf - Browse repository at this point
Copy the full SHA e8f93cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for eeb1513 - Browse repository at this point
Copy the full SHA eeb1513View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3b1779 - Browse repository at this point
Copy the full SHA f3b1779View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfec6b4 - Browse repository at this point
Copy the full SHA bfec6b4View commit details -
- Put element-internals file under lib/ and export out of index - Augment ARIAMixin interface - Export const for hydrate-internals- prefix
Configuration menu - View commit details
-
Copy full SHA for d581707 - Browse repository at this point
Copy the full SHA d581707View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88038e5 - Browse repository at this point
Copy the full SHA 88038e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcef2b4 - Browse repository at this point
Copy the full SHA dcef2b4View commit details
Commits on Mar 21, 2023
-
- Throw on repeat call to `attachInternals()`. - Add warning for `checkValidity()` calls. - Retype and rename `ariaMixinEnum` to `ariaMixinAttributes`. - Loop through ariaAttrMap instead of internals instance.
Configuration menu - View commit details
-
Copy full SHA for 056a39c - Browse repository at this point
Copy the full SHA 056a39cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.