Always show panel if a menu is open on it #11779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to auto hide The problem is that the panel reports it's not visible even though it is, so the x,y calculation for PopupMenus are incorrect. Panels are not hidden until `global.menuStackLength` is bigger than one (meaning a PopupMenu is open for example)
Gr3q
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of the current policy of "Don't hide the panel if a menu is open on it". With this, if you open an applet with a keybinding, the panel for it will also show.
I made these changes for another PR, so I thought I open it. Discuss it among yourselves if it's really needed.
Maybe it can be turned into an optional toggle (feature) turning this change into a conditional.