Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic sizing of thumbnails in alt+tab window selector #11682

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

zipzorp
Copy link

@zipzorp zipzorp commented Jun 3, 2023

Added dynamic thumbnail sizing for thumbnail-only alt+tab window selector. Improved icon sizing for icon-only alt+tab window selector.

Added dynamic thumbnail sizing for thumbnail-only alt+tab window selector. Improved icon sizing for icon-only alt+tab window selector.
@zipzorp zipzorp changed the title Update classicSwitcher.js Dynamic sizing of thumbnails in alt+tab window selector Jun 3, 2023
@mtwebster
Copy link
Member

I think maybe the 256 is too much - this affects icon+thumbnail mode also, and in my 1080 monitor the previews drop to the bottom of my monitor.

With a netbook-sized monitor:
Screenshot from 2023-06-05 10-18-30

I don't mind increasing the icon size a bit but maybe 128 max or something. Any bigger and we would have to start taking the monitor's size into account, and adjusting dynamically based on that. (which may not be a bad idea, but it can be looked at later)

@mtwebster mtwebster added the Blocked Needs rebase, changes, or discussion label Jun 5, 2023
@Secret-chest
Copy link
Contributor

What about 4K 27" at 150%?

@zipzorp
Copy link
Author

zipzorp commented Jun 5, 2023

I think maybe the 256 is too much - this affects icon+thumbnail mode also, and in my 1080 monitor the previews drop to the bottom of my monitor.

With a netbook-sized monitor: (image removed from reply quote for size)

I don't mind increasing the icon size a bit but maybe 128 max or something. Any bigger and we would have to start taking the monitor's size into account, and adjusting dynamically based on that. (which may not be a bad idea, but it can be looked at later)

You're right about that. I made the icon size changes based on 1080p -to-4k screens only, and I did not alter the icon sizing function. On higher res screens the icons were too small in my opinion. I will submit a new commit soon with dynamically sized icons as well with better dimensions for lower res screens.

Thank you for your feedback.

@zipzorp
Copy link
Author

zipzorp commented Jun 6, 2023

Updates made to fit smaller screens and UI scaling better. Made the label dynamically sized as well (in my opinion, the original cinnamon styling is far too small on higher resolution screens)
Icons only, 1280x768
icononly_768

Icons only, 1920x1080
iconsonly_1080

Icons only, 3480x2160
iconsonly_4k

Icons only, 3480x2160 with 150% scaling
iconsonly_4k_150scaling

Thumbnails only, 1360x768
thumbnailsonly_768

Thumbnails only, 1920x1080
thumbnailsonly_1080p

Thumbnails only, 3480x2160
thumbnailsonly_4k

Thumbnails only, 3480x2160 with 150% scaling
thumbnailsonly_4k_150scaling

@mtwebster
Copy link
Member

The icon sizes look good now, but the text size I'm getting doesn't look like your screenshots, it's way too big, and gets ellipsized 8 characters in.

  • 1920x1080: it looks ok, but still much larger than before
  • 3840x2160 hidpi (scaled to 1920x1080): The text is too large
  • 1024x768: Too large

I don't have any text scaling, and my font sizes are 10-11.

pics:
hidpi 1920x1080 (too big):
hidpi-1920x1080

3840x2160 (looks ok):

3840x2160

1024x768 (too big):
1024x768

@zipzorp
Copy link
Author

zipzorp commented Jun 6, 2023

The icon sizes look good now, but the text size I'm getting doesn't look like your screenshots, it's way too big, and gets ellipsized 8 characters in.

* 1920x1080:  it looks ok, but still much larger than before

* 3840x2160 hidpi (scaled to 1920x1080): The text is too large

* 1024x768: Too large

I don't have any text scaling, and my font sizes are 10-11.

Not too big in my opinion. Your opinion is different and that's fine. Like how it's my opinion that the default text is far too small. To me the larger text looks perfect.

I've made changes to suite your personal preference better. I will add options to the window configuration app so that users may configure their own min and max font sizes.

1024x768
thumbnails_768

1920x1200
thumbnails_1920x1200

@zipzorp zipzorp marked this pull request as draft June 6, 2023 17:05
@zipzorp
Copy link
Author

zipzorp commented Jun 7, 2023

Latest commit should make everyone happy. You can now set maximum thumbnail sizes and minimum text sizes through the "Windows" settings window. Can add further customization based on request.

Thumbnail max size 400px
thumbnails_2560x1440_400max

Thumbnail max size 1000px
thumbnails_2560x1440_1000max

2560x1440 12pt
thumbnails_2560x1440

2560x1440 20pt
thumbnails_2560x1440_20pt

@Secret-chest
Copy link
Contributor

I don't understand. Window titles always use a regular font size except here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Needs rebase, changes, or discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants