Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lilconfig #1362

Merged
merged 1 commit into from Dec 2, 2023
Merged

Update lilconfig #1362

merged 1 commit into from Dec 2, 2023

Conversation

antonk52
Copy link
Contributor

Hi, lilconfig maintainer here 👋

I have recently released a new major version that is fully compatible with how it is currently used.

Hope this helps!

Copy link

changeset-bot bot commented Nov 20, 2023

🦋 Changeset detected

Latest commit: 1fbfbcf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
lint-staged Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iiroj
Copy link
Member

iiroj commented Nov 21, 2023

Thanks! Commit message could be chore(deps): update lilconfig@3.0.0 to pass the commit linter, and you also need to add a changeset file using npx changeset. Let me know if you want me to handle these, that's fine. 👍

@antonk52
Copy link
Contributor Author

Thanks. I've updated the commit message and added the changelog entry. This should do it

@iiroj
Copy link
Member

iiroj commented Nov 30, 2023

I'm seeing some failing tests in this branch with npm test.

@antonk52
Copy link
Contributor Author

antonk52 commented Dec 1, 2023

Thanks for the ping. It looks like the test was relying on empty cache in the searcher. I have disabled the cache to ensure the identical behaviour for the tests. The test have passed for me locally.

@iiroj
Copy link
Member

iiroj commented Dec 2, 2023

I will open a PR for updating the test snapshots, seems to be a separate issue in main.

@iiroj iiroj mentioned this pull request Dec 2, 2023
@iiroj
Copy link
Member

iiroj commented Dec 2, 2023

@antonk52 can you rebase on top of master now? You should also try leaving the cache setting enabled because I disabled lilconfig entirely when in the situation lint-staged already has a possible config file from git (and can just directly load it).

@iiroj iiroj merged commit 17bc480 into lint-staged:master Dec 2, 2023
17 checks passed
@github-actions github-actions bot mentioned this pull request Dec 2, 2023
@antonk52
Copy link
Contributor Author

antonk52 commented Dec 2, 2023

Thanks for updating the branch and merging 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants