Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for package.y[a]ml #1344

Merged
merged 4 commits into from Nov 11, 2023
Merged

Add support for package.y[a]ml #1344

merged 4 commits into from Nov 11, 2023

Conversation

danielbayley
Copy link
Contributor

Closes #1343.

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023 •
edited

🦋 Changeset detected

Latest commit: 0e26f51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
lint-staged Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielbayley danielbayley mentioned this pull request Oct 27, 2023
Closed
@iiroj
Copy link
Member

iiroj commented Oct 27, 2023

Thanks for the PR! Could we leave json5 out? I don't really want to introduce a new dependency at this point and npm doesn't support the format anyway.

iiroj
iiroj reviewed Oct 27, 2023
View reviewed changes
lib/loadConfig.js Outdated Show resolved Hide resolved
@danielbayley
Copy link
Contributor Author

danielbayley commented Oct 30, 2023 •
edited

Could we leave json5 out? I don't really want to introduce a new dependency at this point

Done.

npm doesn't support the format anyway.

@iiroj Ah looks like I didn’t quite make that clear in #1343, but pnpm did actually add support for package.json5 along with package.yaml—the main point of this PR—in pnpm/pnpm#1799. I am much less concerned with support for that format however, since I personally use YAML over JSON wherever possible! So, happy to remove…

@danielbayley danielbayley changed the title Add support for package.{yaml,json5} Add support for package.y[a]ml Oct 31, 2023
iiroj
iiroj previously approved these changes Nov 11, 2023
View reviewed changes
@iiroj iiroj merged commit 70487af into lint-staged:master Nov 11, 2023
17 checks passed
@github-actions github-actions bot mentioned this pull request Nov 11, 2023
Merged
@danielbayley danielbayley mentioned this pull request Mar 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iiroj iiroj iiroj approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Also find lint-staged config in package.yaml manifest (support pnpm)
2 participants
@danielbayley @iiroj