Use fetch-depth: 0 in docker-build workflow #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry for poetry dynamic versioning
|
Confirmed that this got the version number correct when building from a branch: https://github.com/linkml/linkml/actions/runs/8425340322/job/23071197801?pr=2022#step:7:2205 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2022 +/- ##
=======================================
Coverage 80.69% 80.69%
=======================================
Files 104 104
Lines 11622 11622
Branches 2910 2910
=======================================
Hits 9378 9378
Misses 1701 1701
Partials 543 543 ☔ View full report in Codecov by Sentry. |
sneakers-the-rat
approved these changes
Mar 25, 2024
|
correct version can be observed here: https://github.com/linkml/linkml/actions/runs/8425340322/job/23071197801?pr=2022#step:7:2205 edit ope you already linked to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2007
Replaces #2017
The docs for
fetch-depthsay thatThis change may increase resource usage when doing a checkout, but in practice I don't think we'll notice a difference. On the other hand it will allow Poetry dynamic versioning to divine the correct version number when run off a tag or a branch.