Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: enable slither CI validation #22

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Build: enable slither CI validation #22

merged 4 commits into from
Mar 6, 2024

Conversation

tamtamchik
Copy link
Member

@tamtamchik tamtamchik commented Feb 9, 2024

Do not merge this PR into develop, yet.


Done using workaround from github/codeql-action#2117

Copy link

github-actions bot commented Feb 9, 2024

badge

Code Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  ------------
contracts/0.4.24/Lido.sol                                        212      18  91.51%   683-722, 814
contracts/0.4.24/StETH.sol                                        72       6  91.67%   294, 356-360
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       5  0.00%    26-47
contracts/0.4.24/lib/SigningKeys.sol                              36      36  0.00%    25-177
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   485     485  0.00%    208-1450
contracts/0.4.24/oracle/LegacyOracle.sol                          72      72  0.00%    114-399
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17      11  35.29%   70-116
contracts/0.8.9/BeaconChainDepositor.sol                          21      19  9.52%    47-88
contracts/0.8.9/Burner.sol                                        71      71  0.00%    140-380
contracts/0.8.9/DepositSecurityModule.sol                        104       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16      16  0.00%    64-121
contracts/0.8.9/LidoLocator.sol                                   18       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28      28  0.00%    16-73
contracts/0.8.9/StakingRouter.sol                                303     296  2.31%    157-1318
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               21      21  0.00%    56-123
contracts/0.8.9/lib/Math.sol                                       4       4  0.00%    9-29
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22      22  0.00%    88-172
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/lib/UnstructuredStorage.sol                        8       3  62.50%   13, 21, 29
contracts/0.8.9/oracle/AccountingOracle.sol                      171     171  0.00%    153-881
contracts/0.8.9/oracle/BaseOracle.sol                             89      89  0.00%    104-410
contracts/0.8.9/oracle/HashConsensus.sol                         263     263  0.00%    249-1094
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                91      91  0.00%    96-461
contracts/0.8.9/proxy/OssifiableProxy.sol                         17      16  5.88%    29-87
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      171     171  0.00%    156-791
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
contracts/common/lib/ECDSA.sol                                     8       0  100.00%
contracts/common/lib/Math256.sol                                   6       6  0.00%    13-42
contracts/common/lib/MemUtils.sol                                  8       8  0.00%    14-64
contracts/common/lib/MinFirstAllocationStrategy.sol               27      27  0.00%    35-105
contracts/common/lib/SignatureUtils.sol                           10       0  100.00%
TOTAL                                                           2857    1955  31.57%

Diff against master

Filename                                       Stmts    Miss  Cover
-------------------------------------------  -------  ------  -------
contracts/0.4.24/StETHPermit.sol                   0      -2  +13.33%
contracts/0.8.9/EIP712StETH.sol                    0      -1  +6.25%
contracts/0.8.9/WithdrawalQueue.sol                0     -74  +84.09%
contracts/0.8.9/WithdrawalQueueERC721.sol          0     -30  +33.71%
contracts/0.8.9/lib/UnstructuredStorage.sol        0      -1  +12.50%
TOTAL                                              0    -108  +3.78%

Results for commit: ebb3303

Minimum allowed coverage is 0%

♻️ This comment has been updated with latest results

@tamtamchik tamtamchik marked this pull request as ready for review February 9, 2024 10:42
@tamtamchik tamtamchik changed the title Build: enable slither CI validation. Build: enable slither CI validation Feb 9, 2024
@tamtamchik
Copy link
Member Author

tamtamchik commented Feb 9, 2024

Got a new type of error 😔

Advanced Security must be enabled for this repository to use code scanning.

As I understand, it is enabled for the lido-dao repo, so it should also be enabled for that one.
@Vinnie161 Can you elaborate on that? Nevermind, will be fixed when the repo goes public.

@tamtamchik
Copy link
Member Author

Do not merge this PR into development branch, yet.

# Conflicts:
#	.github/workflows/analyse.yml
#	package.json
#	pnpm-lock.yaml
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@tamtamchik tamtamchik marked this pull request as ready for review March 6, 2024 12:19
@tamtamchik tamtamchik merged commit 2b2a829 into develop Mar 6, 2024
6 checks passed
@tamtamchik tamtamchik deleted the feat/ci branch March 6, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure advanced security policy enabled for the code scanning
1 participant