Connect tests to CI

[tamtamchik]

Changes:

• Added CI check for Solidity and TS linters
• Added CI check for TS type check
• Added CI contract validation with Slither (disabled because of the bug on GitHub side codeql/upload-sarif@v3 action failed: Resource not accessible by integration - missing actions: read github/codeql-action#2117)

Misc:

• Fix lockfile issue: If install github package use pnpm, pnpm-lock.yml file should not use the format of git@github.com+xxx pnpm/pnpm#7517
• Added import formatting to improve readability and maintainability

Recommendation:

• For JetBrains products users enable:
  Settings | Languages & Frameworks | JavaScript | Code Quality Tools | ESLint | Run eslint --fix on save

[tamtamchik]

@Vinnie161, can you please assist me in resolving an error I am facing? The error message is available at this URL: https://github.com/lidofinance/core/actions/runs/7829024030/job/21360112586?pr=18. I believe repository security settings require some changes to enable SARIF file uploads. As this is a private repository, the security settings may differ from lido-dao, where the same code works fine. Could you please help me with this issue?

Also, would appreciate it if you could review the GitHub Actions workflow jobs.

cc: @TheDZhon

[tamtamchik]

@Vinnie161, there is an error on the runner side: github/codeql-action#2117, so probably nothing can be done for now. Waiting for the fix from codeql-action team.

[github-actions]

🧪 Test coverage: 14.60%

Code Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  -----------------------------------------------------
contracts/0.4.24/Lido.sol                                        212     172  18.87%   369-388, 406-625, 645, 665-1077, 1129-1136, 1181-1381
contracts/0.4.24/StETH.sol                                        72      20  72.22%   287-294, 331-360, 492-506
contracts/0.4.24/StETHPermit.sol                                  15       2  86.67%   130-149
contracts/0.4.24/lib/Packed64x4.sol                                5       5  0.00%    26-47
contracts/0.4.24/lib/SigningKeys.sol                              36      36  0.00%    25-177
contracts/0.4.24/lib/StakeLimitUtils.sol                          37      28  24.32%   99-107, 124-200, 225-229
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   485     485  0.00%    208-1450
contracts/0.4.24/oracle/LegacyOracle.sol                          72      72  0.00%    114-399
contracts/0.4.24/utils/Pausable.sol                                9       4  55.56%   28-35
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17      11  35.29%   70-116
contracts/0.8.9/BeaconChainDepositor.sol                          21      19  9.52%    47-88
contracts/0.8.9/Burner.sol                                        71      71  0.00%    140-380
contracts/0.8.9/DepositSecurityModule.sol                        104       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       1  93.75%   75
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16      16  0.00%    64-121
contracts/0.8.9/LidoLocator.sol                                   18       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28      28  0.00%    16-73
contracts/0.8.9/StakingRouter.sol                                303     296  2.31%    157-1318
contracts/0.8.9/WithdrawalQueue.sol                               88      74  15.91%   89-116, 148-370, 384-392, 397, 400-413
contracts/0.8.9/WithdrawalQueueBase.sol                          146     129  11.64%   123-353, 394-542, 556-557, 582-594
contracts/0.8.9/WithdrawalQueueERC721.sol                         89      30  66.29%   110-159, 213, 244, 270, 273, 332, 351-392
contracts/0.8.9/WithdrawalVault.sol                               21      21  0.00%    56-123
contracts/0.8.9/lib/Math.sol                                       4       4  0.00%    9-29
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22      22  0.00%    88-172
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/lib/UnstructuredStorage.sol                        8       4  50.00%   13-21, 29
contracts/0.8.9/oracle/AccountingOracle.sol                      171     171  0.00%    153-881
contracts/0.8.9/oracle/BaseOracle.sol                             89      89  0.00%    104-410
contracts/0.8.9/oracle/HashConsensus.sol                         263     263  0.00%    249-1094
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                91      91  0.00%    96-461
contracts/0.8.9/proxy/OssifiableProxy.sol                         17      16  5.88%    29-87
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      171     171  0.00%    156-791
contracts/0.8.9/utils/PausableUntil.sol                           31      29  6.45%    28-40, 46, 60-100
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23      15  34.78%   80-81, 106-174, 205-207, 228-230
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       4  55.56%   51-59, 74-75
contracts/common/lib/ECDSA.sol                                     8       0  100.00%
contracts/common/lib/Math256.sol                                   6       6  0.00%    13-42
contracts/common/lib/MemUtils.sol                                  8       8  0.00%    14-64
contracts/common/lib/MinFirstAllocationStrategy.sol               27      27  0.00%    35-105
contracts/common/lib/SignatureUtils.sol                           10       0  100.00%
TOTAL                                                           2857    2440  14.60%

Results for commit: 08faf9c

Minimum allowed coverage is 0%

♻️ This comment has been updated with latest results

[TheDZhon]

Splendid! 👍

I'd suggest implementing a small set of changes before merging this PR 🙏

[TheDZhon]

LGTM 👍

[mymphe]

Amazing!