Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align wait-for-it host with libreoffice start command #7

Merged
merged 1 commit into from Mar 27, 2024

Conversation

fetwar
Copy link
Contributor

@fetwar fetwar commented Mar 21, 2024

libreoffice start command uses the loopback address 127.0.0.1 instead of localhost.

This can cause issues in resolving to the correct address if:

  • The host machine uses external DNS resolution only and Docker DNS is not explicitly set.
  • /etc/nsswitch.conf is set to not check local files first.
  • The Docker DNS resolution is set for external name resolution only.

This ensures that regardless of DNS resolution issues on the host machine, the container will be able to run, since it doesn't really need these anyway.

@fetwar
Copy link
Contributor Author

fetwar commented Mar 21, 2024

Please note, tests failed after the last commit ~3 months ago, I tried to fix this issue as well, but the Github actions logs have expired.

@fetwar
Copy link
Contributor Author

fetwar commented Mar 24, 2024

@socheatsok78

@mlarue
Copy link

mlarue commented Mar 26, 2024

Had problems with rest-api not starting up and

127.0.0.1	localhost
::1	localhost ip6-localhost ip6-loopback

in containers /etc/hosts.

Workaround until this is merged:

docker run --rm --sysctl net.ipv6.conf.all.disable_ipv6=1 libreofficedocker/libreoffice-unoserver:3.18

For details see: moby/moby#47062

Copy link
Member

@socheatsok78 socheatsok78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fetwar Totally agree with this, anyway apologies for the wait.

@socheatsok78 socheatsok78 merged commit c12ae09 into libreofficedocker:main Mar 27, 2024
@socheatsok78
Copy link
Member

Please note, tests failed after the last commit ~3 months ago, I tried to fix this issue as well, but the Github actions logs have expired.

The build only failed for the Alpine 3.19, the older releases are fine.

Will take a look at 3.19 later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants