Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spell check with typos. Add spell-check CI job #621

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Spell check with typos. Add spell-check CI job #621

merged 3 commits into from
Jul 19, 2023

Commits on Jul 2, 2023

  1. Spell check with typos. Add spell-check CI job

    @vvv
    vvv committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    b58f711 View commit details
    Browse the repository at this point in the history

  2. Update length_expr_parentheses.stderr 

    Let `tests/compile-fail/length_expr_parentheses.rs` pass.

Console output:

```
test tests/compile-fail/length_expr_parentheses.rs [should fail to compile] ... mismatch

EXPECTED:
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error: this file contains an unclosed delimiter
  --> tests/compile-fail/length_expr_parentheses.rs:15:1
   |
15 | #[packet]
   | ^^^^^^^^^ unclosed delimiter
   |
   = note: this error originates in the derive macro `::pnet_macros::Packet` (in Nightly builds, run with -Z macro-backtrace for more info)
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈

ACTUAL OUTPUT:
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error: this file contains an unclosed delimiter
  --> tests/compile-fail/length_expr_parentheses.rs:15:1
   |
15 | #[packet]
   | ^^^^^^^^^ unclosed delimiter
   |
   = note: this error originates in the derive macro `::pnet_macros::Packet` (in Nightly builds, run with -Z macro-backtrace for more info)

error: proc-macro derive panicked
  --> tests/compile-fail/length_expr_parentheses.rs:15:1
   |
15 | #[packet]
   | ^^^^^^^^^
   |
   = help: message: compiler/fallback mismatch
   = note: this error originates in the attribute macro `packet` (in Nightly builds, run with -Z macro-backtrace for more info)
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
note: If the actual output is the correct output you can bless it by rerunning
      your test with the environment variable TRYBUILD=overwrite
```
    @vvv
    vvv committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    6bdcf95 View commit details
    Browse the repository at this point in the history

  3. Fix "irrefutable while let pattern" warning 

    ```
warning: irrefutable `while let` pattern
  --> examples/arp_packet.rs:61:11
   |
61 |     while let buf = receiver.next().unwrap() {
   |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this pattern will always match, so the loop will never exit
   = help: consider instead using a `loop { ... }` with a `let` inside it
   = note: `#[warn(irrefutable_let_patterns)]` on by default
```
    @vvv
    vvv committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    6f31c07 View commit details
    Browse the repository at this point in the history