Add Repository.revert() #1297
Merged
Add Repository.revert() #1297
+49
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes libgit2's git_revert(), which produces changes in the index and working directory. It also affects the repository's state (via .git/REVERT_HEAD) and prepared message (via .git/MERGE_MSG). The existing function Repository.revert_commit(), which exposes git_revert_commit(), is less powerful -- it doesn't check out the resulting index, and it doesn't modify the state and prepared message. Note: git_revert() takes additional checkout/revert settings. We could implement support for these as extra arguments to Repository.revert() in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes libgit2's git_revert(), which produces changes in the index and working directory. It also affects the repository's state (via .git/REVERT_HEAD) and prepared message (via .git/MERGE_MSG).
Rationale for adding this even though Repository.revert_commit() already exists: revert_commit() is a binding for git_revert_commit(), which is less powerful -- it doesn't check out the resulting index, and it doesn't modify the state and prepared message.
Note: git_revert() accepts additional checkout/revert settings. We could implement support for these as extra arguments to Repository.revert() in the future.