Set GitProxyOptions type to default to auto #2043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've created a NUGET package from this PR. |
|
Thanks for the PR. I've incorporated setting the proxy type to auto by default in my comprehensive PR that adds proxy support, #2065. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1429.
Currently
GitProxyOptions.Typeis set toGitProxyType.noneand it is not possible to use libgit2sharp through a proxy. By settingGitProxyOptions.TypetoGitProxyType.Autogit config settings forhttp.proxyandhttps.proxywork as expected in libgit2sharp.PR #1689 also attempts to address this, but is still open. However, it is not legal to have a field initializer in a struct.
PR #1708 did a nice job of fixing this issue, but it was closed by the author and not merged.
It would be really nice to have this feature in libgit2sharp.