Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(version): update tests to reflect new behavior of semver #3785

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Jul 17, 2023

Description

Updates the publish integration tests to reflect the bug that was fixed in semver - npm/node-semver#533

Motivation and Context

Semver used to consider the difference between "v1.0.0" and "v1.0.0-alpha.0" to be a prerelease. Now it considers that a major version bump. This change means that Lerna will now consider "v1.0.0-alpha.0" to "v1.0.0" a major version bump and therefore breaking change, which triggers the release of all other packages when in fixed mode.

I believe that Lerna's new behavior (due to this semver change) makes sense and is consistent with Lerna's existing pattern of publishing all packages when a breaking change is made.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj force-pushed the chore/update-tests-to-match-semver branch from ff67269 to 8d1d357 Compare July 17, 2023 05:25
@fahslaj fahslaj marked this pull request as ready for review July 17, 2023 05:48
@fahslaj fahslaj requested a review from JamesHenry July 17, 2023 05:48
@fahslaj fahslaj merged commit f421127 into lerna:dependabot/npm_and_yarn/semver-7.5.2 Jul 17, 2023
11 checks passed
@fahslaj fahslaj deleted the chore/update-tests-to-match-semver branch July 17, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant