Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move parameters enums as separate headers #217

Closed
wants to merge 1 commit into from

Conversation

piallai
Copy link

@piallai piallai commented Apr 3, 2024

  • rng_type_t, sample_method_t, schedule_t, sd_type_t can be included without including the whole stable-diffusion.h file
  • SDMode and SDParams are set in separate headers to highlight the main parameters of the API

- rng_type_t, sample_method_t, schedule_t, sd_type_t can be included without including the whole stable-diffusion.h file
- SDMode and SDParams are set in separate headers to highlight the main parameters of the API
@leejet
Copy link
Owner

leejet commented Apr 6, 2024

Thank you for your contribution. But as a C-style api header file, stable-diffusion.h should be kept as simple as possible, using only one file, so I don't think these changes are necessary.

@leejet leejet closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants