Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Rinkeby testnet #7677

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Remove the Rinkeby testnet #7677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,8 +314,8 @@ Example of multiple chains on the same machine:
./build/bin/erigon --datadir="<your_mainnet_data_path>" --chain=mainnet --port=30303 --http.port=8545 --authrpc.port=8551 --torrent.port=42069 --private.api.addr=127.0.0.1:9090 --http --ws --http.api=eth,debug,net,trace,web3,erigon


# rinkeby
./build/bin/erigon --datadir="<your_rinkeby_data_path>" --chain=rinkeby --port=30304 --http.port=8546 --authrpc.port=8552 --torrent.port=42068 --private.api.addr=127.0.0.1:9091 --http --ws --http.api=eth,debug,net,trace,web3,erigon
# sepolia
./build/bin/erigon --datadir="<your_sepolia_data_path>" --chain=sepolia --port=30304 --http.port=8546 --authrpc.port=8552 --torrent.port=42068 --private.api.addr=127.0.0.1:9091 --http --ws --http.api=eth,debug,net,trace,web3,erigon
```

Quote your path if it has spaces.
Expand Down
2 changes: 0 additions & 2 deletions cmd/erigon-el/backend/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ func NewNodConfigUrfave(ctx *cli.Context, logger log.Logger) *nodecfg.Config {
switch chain {
case networkname.SepoliaChainName:
logger.Info("Starting Erigon on Sepolia testnet...")
case networkname.RinkebyChainName:
logger.Info("Starting Erigon on Rinkeby testnet...")
case networkname.GoerliChainName:
logger.Info("Starting Erigon on Görli testnet...")
case networkname.DevChainName:
Expand Down
2 changes: 1 addition & 1 deletion cmd/integration/commands/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ var (
pruneHBefore, pruneRBefore uint64
pruneTBefore, pruneCBefore uint64
experiments []string
chain string // Which chain to use (mainnet, rinkeby, goerli, etc.)
chain string // Which chain to use (mainnet, goerli, sepolia, etc.)

commitmentMode string
commitmentTrie string
Expand Down
2 changes: 1 addition & 1 deletion cmd/rpcdaemon/postman/RPC_Testing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@
"raw": "{{HOST}}",
"host": ["{{HOST}}"]
},
"description": "Returns the current network id.\r\n\r\n**Parameters**\r\n\r\nNone\r\n\r\n**Returns**\r\n\r\nSTRING - The current network id. One of BR \"1\": Ethereum Mainnet BR \"4\": Rinkeby Testnet BR \"5\": Görli Testnet BR"
"description": "Returns the current network id.\r\n\r\n**Parameters**\r\n\r\nNone\r\n\r\n**Returns**\r\n\r\nSTRING - The current network id. One of BR \"1\": Ethereum Mainnet BR \"5\": Görli Testnet BR \"11155111\": Sepolia Testnet BR"
},
"response": []
},
Expand Down
2 changes: 0 additions & 2 deletions common/paths/paths.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,6 @@ func DataDirForNetwork(datadir string, network string) string {
switch network {
case networkname.DevChainName:
return "" // unless explicitly requested, use memory databases
case networkname.RinkebyChainName:
return networkDataDirCheckingLegacy(datadir, "rinkeby")
case networkname.GoerliChainName:
return networkDataDirCheckingLegacy(datadir, "goerli")
case networkname.MumbaiChainName:
Expand Down
2 changes: 1 addition & 1 deletion consensus/clique/clique_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import (
)

// This test case is a repro of an annoying bug that took us forever to catch.
// In Clique PoA networks (Rinkeby, Görli, etc), consecutive blocks might have
// In Clique PoA networks (e.g. Görli), consecutive blocks might have
// the same state root (no block subsidy, empty block). If a node crashes, the
// chain ends up losing the recent state and needs to regenerate it from blocks
// already in the database. The bug was that processing the block *prior* to an
Expand Down