Support building with rustls but native certificates #3551
Merged
+69
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IlyaBizyaev can you amend and force-push to trigger new CI runs? |
IlyaBizyaev
force-pushed
the
feature/rustls-native-certs
branch
2 times, most recently
from
7048aae to
5631054
Compare
This adds an alternative TLS configuration that relies on rustls-native-certs, for users who cannot bundle the MPL-licensed webpki-roots. The approach is copied from reqwest: * https://github.com/seanmonstar/reqwest/blob/3ad6e02cd/Cargo.toml#L48 * https://github.com/seanmonstar/reqwest/blob/3ad6e02cd/src/async_impl/client.rs#L513 — except error handling is relaxed to accommodate for tls_config.root_cert_path.
IlyaBizyaev
force-pushed
the
feature/rustls-native-certs
branch
from
5631054 to
e62fa65
Compare
|
There was a problem with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an alternative TLS configuration that relies on
rustls-native-certs, for users who cannot bundle the MPL-licensedwebpki-roots.The approach is copied from
reqwest:— except error handling is relaxed to accommodate for
tls_config.root_cert_path.