Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to override the cache file path in command line #255

Conversation

jimmyklein-actual
Copy link
Contributor

Hi,

We have a internal bundle that defined the code style for all our projects. This bundle is therefore shared by multiple projects.

We need to have the possibility to define, by project, the path of the pint cache file.

This pull request allow the user to do it by given the path of the cache file in the command line.

We have a bundle that defined the code style for all our projects. This bundle is therefore shared by multiple projects.
We need to have the possibility to define, by project, the path of the cache file.

This pull request allow the user to do it by given the path of the cache file in the command line.
@Vectorial1024
Copy link

By very pure coincidence, you may also want to review laravel/docs#9502

@Vectorial1024
Copy link

@jimmyklein-actual would the existing feature described in the above PR sufficient in your use case? Or would you still want to add a command line option for future usage by others?

@jimmyklein-actual
Copy link
Contributor Author

jimmyklein-actual commented Mar 15, 2024

By very pure coincidence, you may also want to review laravel/docs#9502

Ok, it would be great if my PR is OK to also add it in the documentation.

would the existing feature described in the above PR sufficient in your use case? Or would you still want to add a command line option for future usage by others?

Sorry I don't understand your question.
By addind the possibility to configure cache file path in the command line, it will allow me to specify by project where I want the cache file to be stored.
I am not sure that I answer to your question.

@Vectorial1024
Copy link

Oh wait, perhaps what you mean is, you share the coding style across many projects (e.g. the same PSR-12 for many projects), but the cache files for each project are separate?

Then yes, a command line option to specify cache file is good. I understand now.

@taylorotwell taylorotwell merged commit fb4e240 into laravel:main Mar 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants