Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPUnit constraint #6389

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Fix PHPUnit constraint #6389

merged 1 commit into from
Apr 3, 2024

Conversation

szepeviktor
Copy link
Contributor

there was a BC break in PHPUnit sebastianbergmann/phpunit#5690

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Apr 3, 2024 •
edited

... resulting in

Non-readonly class Illuminate\Testing\Constraints\ArraySubset cannot extend readonly class PHPUnit\Framework\Constraint\Constraint

@driesvints driesvints merged commit 708fdb1 into laravel:11.x Apr 3, 2024
5 checks passed
@driesvints
Copy link
Member

Thanks! Normally this constraint is already pulled in but can't hurt to have as the default.

@szepeviktor
Copy link
Contributor Author

Thank you for merging it.
I encourage developers to run tests with lowest/locked/highest dependencies.

@szepeviktor szepeviktor deleted the patch-1 branch April 3, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@szepeviktor @driesvints