[12.x] Fix Concurrency::run to preserve callback result order #55161
+39
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation of
Concurrency::run()
withfork
driver does not preserve the original order of callbacks when returning results. This leads to incorrect variable assignment when destructuring the return value, as shown in the documentation example:If the second callback completes before the first, the results array may be returned in a different order, causing
$userCount
and$orderCount
to be swapped.Solution
This PR modifies the
ForkDriver::run
method to associate results with their original keys and return them in the original order after all tasks are completed.