[12.x] Update DateFactory method annotations for Carbon v3 compatibility #55151
+51
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayw-geek
changed the title
|
Should we consider using the |
calebdw
added a commit
to calebdw/larastan
that referenced
this pull request
Apr 1, 2025
The methods `maxValue` and `minValue` are not available in the `Date` class. This removes the assertions for these methods. See: laravel/framework#55151
calebdw
added a commit
to calebdw/larastan
that referenced
this pull request
Apr 1, 2025
The methods `maxValue` and `minValue` are not available in the `Date` class. This removes the assertions for these methods. See: laravel/framework#55151
nunomaduro
pushed a commit
to larastan/larastan
that referenced
this pull request
Apr 3, 2025
The methods `maxValue` and `minValue` are not available in the `Date` class. This removes the assertions for these methods. See: laravel/framework#55151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Synchronizes method annotations in
DateFactorywith the latest Carbon v3 Factory class. This ensures our type definitions exactly match the upstream Carbon library's implementation.Reference: briannesbitt/Carbon Factory.php
Impact
This is a documentation-only change that ensures our type definitions stay in sync with Carbon. It improves:
No runtime behavior is affected.