Better return types for Illuminate\Queue\Jobs\Job::getJobId() and Illuminate\Queue\Jobs\DatabaseJob::getJobId() methods
#55138
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the silence at #55080 I guess the correct smallest data type from implementation. Based on observation and method
Illuminate\Database\Query\Builder::findI changedIlluminate\Queue\Jobs\DatabaseJob::getJobIdtostring|intand based on all implementations ofIlluminate\Queue\Jobs\Job::getJobIdin this repository I changed its return type tostring|int|null(as DB job returnsstdClass::$id, both should bemixed).Benefit to end users - this version will not lead to fatal errors (if other annotations are correct).
Children MUST respect it's parent. You can't expand parents return type in it's children, you only can make the children return more specific, for more information visit https://en.wikipedia.org/wiki/Inheritance_(object-oriented_programming).